-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#226] Update to manage secrets with Github Environments for Staging and Production #263
Conversation
fe4e85d
to
9ecccf7
Compare
9ecccf7
to
15f03a5
Compare
15f03a5
to
42d1758
Compare
bricks/template/__brick__/{{project_name.snakeCase()}}/ios/fastlane/Constants/Environments.rb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to check and update writing multiple lines later. Look good so far 👍
@doannimble It has been verified to work properly with this .env structure https://github.com/nimblehq/flutter-templates/blob/develop/sample/.env.sample ✅ |
Nice @luongvo . Actually, it can write and read, but it may be incorrect. Have you tried to print out |
@doannimble Yes, the last build can not run to show the staging name with a black screen flutter-templates/sample/lib/main.dart Lines 117 to 123 in b2851fd
|
What happened 👀
Environments
config.Insight 📝
""
https://stackoverflow.com/a/22101842/2100084 ✅ENV_PRODUCTION
andENV_STAGING
have been moved to theEnvironments
✅FIREBASE_ANDROID_APP_ID_PRODUCTION
,FIREBASE_ANDROID_APP_ID_STAGING
,FIREBASE_IOS_APP_ID_PRODUCTION
, andFIREBASE_IOS_APP_ID_STAGING
have been converted to variables and moved to theEnvironments
✅ANDROID_SIGNING_PROPERTIES_BASE64
is now becomeANDROID_SIGNING_PROPERTIES
without base64 encoded by usinga multi-line variable
✅Proof Of Work 📹
The
bump_version
workflow works properly without token to check out https://github.com/nimblehq/flutter-templates/actions/runs/5746348294/job/15575671352 👉 [Chore] Bump version to 1.11.1 #264 ✅Updated secrets & variables management by using
Environment
The app can read secrets properly from .env