Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#229] [Android] Add missing signing config in CD workflows #254

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[#229] [Android] Add missing signing config in CD workflows #254

merged 1 commit into from
Aug 1, 2023

Conversation

luongvo
Copy link
Member

@luongvo luongvo commented Jul 31, 2023 •
edited
Loading

What happened 👀

Insight 📝

  • This step is needed only when building the release build.
  • We must use base64 to encode and decode the keystore & signing.properties to ensure the binary file content.

Proof Of Work 📹

https://github.com/nimblehq/flutter-templates/actions/runs/5722187525/job/15504868438 ✅

@luongvo luongvo added this to the 1.10.0 milestone Jul 31, 2023
@luongvo luongvo self-assigned this Jul 31, 2023
@luongvo luongvo linked an issue Jul 31, 2023 that may be closed by this pull request
[Android] Add signing config for debug and release builds #229
Closed
@luongvo luongvo force-pushed the feature/229-add-signing-config-in-workflow branch 3 times, most recently from d592411 to 663c06b Compare August 1, 2023 03:17
@luongvo luongvo force-pushed the feature/229-add-signing-config-in-workflow branch from 663c06b to b25a3fb Compare August 1, 2023 03:33
@luongvo luongvo marked this pull request as ready for review August 1, 2023 03:33
doannimble
doannimble reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

.github/workflows/android_deploy_production_to_playstore.yml Show resolved Hide resolved
...__/{{project_name.snakeCase()}}/.github/workflows/android_deploy_production_to_playstore.yml Show resolved Hide resolved
doannimble
doannimble approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the branch then we can go 🏃‍♂️

@luongvo luongvo force-pushed the feature/229-add-signing-config-in-workflow branch from b25a3fb to e4304a0 Compare August 1, 2023 04:08
@luongvo luongvo temporarily deployed to staging August 1, 2023 04:08 — with GitHub Actions Inactive
@luongvo luongvo force-pushed the feature/229-add-signing-config-in-workflow branch from e4304a0 to e2362bc Compare August 1, 2023 04:10
@luongvo luongvo temporarily deployed to staging August 1, 2023 04:10 — with GitHub Actions Inactive
@luongvo luongvo marked this pull request as draft August 1, 2023 04:13
@luongvo luongvo force-pushed the feature/229-add-signing-config-in-workflow branch from e2362bc to b25a3fb Compare August 1, 2023 04:25
@luongvo
Copy link
Member Author

luongvo commented Aug 1, 2023

@doannimble To speed up the release, I will fix to use echo -e later in #226 👋

@luongvo luongvo marked this pull request as ready for review August 1, 2023 04:26
@luongvo luongvo merged commit 48f7760 into develop Aug 1, 2023
@luongvo luongvo deleted the feature/229-add-signing-config-in-workflow branch August 1, 2023 08:15
@luongvo luongvo mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doannimble doannimble doannimble approved these changes

@nmint8m nmint8m nmint8m approved these changes

@manh-t manh-t Awaiting requested review from manh-t manh-t is a code owner

@markgravity markgravity Awaiting requested review from markgravity markgravity is a code owner

@sleepylee sleepylee Awaiting requested review from sleepylee sleepylee is a code owner

@chornerman chornerman Awaiting requested review from chornerman chornerman is a code owner

@hoangnguyen92dn hoangnguyen92dn Awaiting requested review from hoangnguyen92dn hoangnguyen92dn is a code owner

@ducbm051291 ducbm051291 Awaiting requested review from ducbm051291 ducbm051291 is a code owner

@thiennguyen0196 thiennguyen0196 Awaiting requested review from thiennguyen0196

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@Wadeewee Wadeewee Awaiting requested review from Wadeewee

Assignees

@luongvo luongvo

Labels
type : feature
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

[Android] Add signing config for debug and release builds
3 participants
@luongvo @nmint8m @doannimble