Improve the description in the PR template #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
approved these changes
Jul 8, 2022
Nihisil
reviewed
Jul 8, 2022
Nihisil
approved these changes
Jul 8, 2022
suho
approved these changes
Jul 8, 2022
nvminhtue
approved these changes
Jul 8, 2022
AVI5HEK
approved these changes
Jul 8, 2022
This was referenced Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
Reworked the description for the section "What happened" and "Insight"
Insight 📝
Too often, the section "Insight" is mistaken for the section "What happened". The previous wording could make this confusion happen. Therefore, I brought up the clarification made in https://github.com/nimblehq/compass/pull/980 to the PR template.
Additionally, all active internal and client projects should adopt this new template.
Proof Of Work 📹