Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#340] Update Git Template for Pull Request #341

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

malparty
Copy link
Member

@malparty malparty commented Jul 8, 2022

What happened

Applied the new PR templates for both the template PR and the generated project PR.

Insight

N/A

Proof Of Work

template PR generated project PR
image image

@malparty malparty force-pushed the chore/gh340-update-git-pr-template branch from a715d67 to 7e129c3 Compare July 8, 2022 10:04
@@ -1,13 +1,13 @@
Add the story URL here. Prefer the short link format, e.g. https://app.clubhouse.io/acme/story/1234/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, should we change app.clubhouse.io to app.shortcut.com :D

@andyduong1920
Copy link
Member

Please help to review the similar PR on the Elixir template too nimblehq/elixir-templates#238 😄

@olivierobert olivierobert merged commit 8501ef4 into develop Jul 12, 2022
@olivierobert olivierobert deleted the chore/gh340-update-git-pr-template branch July 12, 2022 06:06
@malparty malparty mentioned this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants