Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Jest tests are failing but CI still passed #113

Closed
hoangmirs opened this issue Aug 26, 2022 · 0 comments · Fixed by #122
Closed

Fix: Jest tests are failing but CI still passed #113

hoangmirs opened this issue Aug 26, 2022 · 0 comments · Fixed by #122
Assignees
@hoangmirs
Labels
type : bug Something isn't working
Milestone
1.3.0

Comments

@hoangmirs
Copy link
Collaborator

Issue

Jest tests are failing but CI still passed

_63__Add_Terraform_codebase·_nimblehq_infrastructure-templates_7985803

Reference: https://github.com/nimblehq/infrastructure-templates/runs/8032298277?check_suite_focus=true

Expected

CI should fail when there is any failed tests

Steps to reproduce
@hoangmirs hoangmirs added the type : bug Something isn't working label Aug 26, 2022
hoangmirs added a commit that referenced this issue Sep 25, 2022
@hoangmirs
[#113] Fix: Jest tests are failing but CI still passed
d65d0ff
@hoangmirs hoangmirs mentioned this issue Sep 25, 2022
Merged
@hoangmirs hoangmirs self-assigned this Sep 25, 2022
@hoangmirs hoangmirs added this to the 1.3.0 milestone Sep 25, 2022
hoangmirs added a commit that referenced this issue Oct 5, 2022
@hoangmirs
Merge pull request #122 from nimblehq/bug/113-fix-wrong-exit-code-jest
d99fcaf 
[#113] Fix: Jest tests are failing but CI still passed
@hoangmirs hoangmirs mentioned this issue Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangmirs hoangmirs

Labels
type : bug Something isn't working
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

[#113] Fix: Jest tests are failing but CI still passed nimblehq/infrastructure-templates
1 participant
@hoangmirs