Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#113] Fix: Jest tests are failing but CI still passed #122

Merged
merged 5 commits into from
Oct 5, 2022
Merged

[#113] Fix: Jest tests are failing but CI still passed #122

merged 5 commits into from
Oct 5, 2022

Conversation

hoangmirs
Copy link
Collaborator

@hoangmirs hoangmirs commented Sep 25, 2022 •
edited
Loading

What happened 👀

Fix test script

Insight 📝

  • Run Jest with --watch option might cause this issue.
  • You just need to check d65d0ff. The current branch has the code from chaining branch as I merged it 😢

Proof Of Work 📹

Tested on my local machine

@hoangmirs hoangmirs added the type : bug Something isn't working label Sep 25, 2022
@hoangmirs hoangmirs added this to the 1.3.0 milestone Sep 25, 2022
@hoangmirs hoangmirs self-assigned this Sep 25, 2022
@hoangmirs hoangmirs modified the milestone: 1.3.0 Sep 26, 2022
@hoangmirs
Merge pull request #120 from nimblehq/chore/111-enable-sticky-sessions
424cff6 
[#111] Update the load balancer to support sticky sessions
@hoangmirs hoangmirs merged commit d99fcaf into develop Oct 5, 2022
@hoangmirs hoangmirs deleted the bug/113-fix-wrong-exit-code-jest branch October 5, 2022 02:44
@hoangmirs hoangmirs mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyduong1920 andyduong1920 andyduong1920 approved these changes

@longnd longnd longnd approved these changes

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@hanam1ni hanam1ni Awaiting requested review from hanam1ni

@junan junan Awaiting requested review from junan

@rosle rosle Awaiting requested review from rosle

@Nihisil Nihisil Awaiting requested review from Nihisil Nihisil is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@Lahphim Lahphim Awaiting requested review from Lahphim

@malparty malparty Awaiting requested review from malparty malparty is a code owner

Assignees

@hoangmirs hoangmirs

Labels
type : bug Something isn't working
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Fix: Jest tests are failing but CI still passed
3 participants
@hoangmirs @longnd @andyduong1920