Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tfsec to the CI of the generated project #155

Closed
hoangmirs opened this issue Dec 31, 2022 · 0 comments · Fixed by #178
Closed

Add tfsec to the CI of the generated project #155

hoangmirs opened this issue Dec 31, 2022 · 0 comments · Fixed by #178
Assignees
@Nihisil
Labels
type : feature New feature or request

Comments

@hoangmirs
Copy link
Collaborator

Why

The generated project should be shipped with tfsec when selecting the GitHub add-on. That tool will scan the terraform code to spot potential misconfiguration
We can add a workflow and use tfsec-pr-commenter-action

Who Benefits?

Developers that use GitHub
@hoangmirs hoangmirs added the type : feature New feature or request label Dec 31, 2022
@Nihisil Nihisil self-assigned this Feb 27, 2023
Nihisil added a commit that referenced this issue Mar 24, 2023
@Nihisil
[#155] Add tfsec to generated project template
1a71c6c
@Nihisil Nihisil mentioned this issue Mar 24, 2023
Merged
2 tasks
Nihisil added a commit that referenced this issue Mar 31, 2023
@Nihisil
[#155] Add tfsec to generated project template
b0f8243
Nihisil added a commit that referenced this issue Apr 20, 2023
@Nihisil
[#155] Address tfsec warnings
8a25306
Nihisil added a commit that referenced this issue Apr 20, 2023
@Nihisil
[#155] Address tfsec warnings
40b5523
Nihisil added a commit that referenced this issue Apr 25, 2023
@Nihisil
[#155] Add tfsec to generated project template
c07090b
Nihisil added a commit that referenced this issue Apr 25, 2023
@Nihisil
[#155] Address tfsec warnings
63f6030
Nihisil added a commit that referenced this issue Apr 25, 2023
@Nihisil
[#155] Add tfsec to generated project template
125afa2
Nihisil added a commit that referenced this issue Apr 25, 2023
@Nihisil
[#155] Address tfsec warnings
6adae42
Nihisil added a commit that referenced this issue Apr 25, 2023
@Nihisil
[#155] Address tfsec warnings
e47d487
hoangmirs added a commit that referenced this issue Apr 25, 2023
@hoangmirs
Merge pull request #178 from nimblehq/feature/155-add-tfsec
4a5ccac 
[#155] Add tfsec to the CI of the generated project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nihisil Nihisil

Labels
type : feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#155] Add tfsec to the CI of the generated project nimblehq/infrastructure-templates
2 participants
@Nihisil @hoangmirs