[#155] Add tfsec to the CI of the generated project #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nihisil
requested review from
andyduong1920,
bterone,
byhbt,
longnd,
malparty,
nvminhtue and
rosle
as code owners
longnd
approved these changes
Mar 28, 2023
|
tfsec is not working correctly because of that bug: #179 I have moved this PR to draft and will revise it after 179 will be fixed. |
Nihisil
force-pushed
the
feature/155-add-tfsec
branch
from
1a71c6c to
b0f8243
Compare
Nihisil
force-pushed
the
feature/155-add-tfsec
branch
from
8a25306 to
40b5523
Compare
longnd
approved these changes
Apr 21, 2023
hoangmirs
reviewed
Apr 24, 2023
Nihisil
force-pushed
the
feature/155-add-tfsec
branch
from
40b5523 to
63f6030
Compare
Nihisil
force-pushed
the
feature/155-add-tfsec
branch
from
63f6030 to
6adae42
Compare
Nihisil
force-pushed
the
feature/155-add-tfsec
branch
from
6adae42 to
e47d487
Compare
|
@malparty It's a great idea! I included a ticket to address an issue that was previously ignored: #189. As for the other issues, some simply don't make sense to address, for instance, forcing encryption for ALB S3 bucket. In other cases, there's some uncertainty whether they should be addressed, such as using a custom KMS key for ECR images. |
hoangmirs
approved these changes
Apr 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
tfsecGH action into the generated project template.TFSEC_VERSIONspecified with the requiredvprefix, astfsecuses this format for release tags.tfsecis included in the.tool-versionsfile for asdf, so that developers can run checks locally during the development process.Insight 📝
Our template had multiple warnings listed by tfsec. A few of these warnings were addressed and resolved accordingly, while others were silenced since they don't have much sense.
Proof Of Work 📹
tfsecaction was initiated and the CI passed.CI for newly generated project: