Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub add-on #61

Closed
andyduong1920 opened this issue Jul 12, 2022 · 0 comments · Fixed by #97
Closed

Add GitHub add-on #61

andyduong1920 opened this issue Jul 12, 2022 · 0 comments · Fixed by #97
Assignees
Labels
type : feature New feature or request
Milestone

Comments

@andyduong1920
Copy link
Member

andyduong1920 commented Jul 12, 2022

Why

  • We haven't added .github folder to the generated project.
  • We need to add:
    • git-template to have issue/pull requests template
    • linting workflow. The workflow could be the following code:
name: Linting

on: pull_request

env:
  TERRAFORM_VERSION: "1.2.4"

jobs:
  linting:
    name: Linting

    runs-on: ubuntu-latest

    timeout-minutes: 5

    steps:
      - name: Cancel previous runs
        uses: styfle/[email protected]
        with:
          access_token: ${{ github.token }}

      - name: Checkout the repository
        uses: actions/checkout@v2
        with:
          ref: ${{ github.head_ref }}

      - name: Install Terraform
        uses: hashicorp/setup-terraform@v2
        with:
          terraform_version: ${{ env.TERRAFORM_VERSION }}

      - name: Run Terraform format
        run: terraform fmt -recursive -check

Who Benefits?

Developer

@hoangmirs hoangmirs added the type : feature New feature or request label Jul 18, 2022
@hoangmirs hoangmirs changed the title Add github linting action on the generated project Add Github add-on Jul 26, 2022
@hoangmirs hoangmirs added this to the 1.2.0 milestone Aug 1, 2022
@hoangmirs hoangmirs self-assigned this Aug 8, 2022
hoangmirs added a commit that referenced this issue Aug 9, 2022
hoangmirs added a commit that referenced this issue Aug 9, 2022
hoangmirs added a commit that referenced this issue Aug 9, 2022
hoangmirs added a commit that referenced this issue Aug 9, 2022
hoangmirs added a commit that referenced this issue Aug 9, 2022
@hoangmirs hoangmirs changed the title Add Github add-on Add GitHub add-on Aug 9, 2022
hoangmirs added a commit that referenced this issue Aug 16, 2022
hoangmirs added a commit that referenced this issue Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type : feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants