Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#61] Add GitHub add-on #97

Merged
merged 10 commits into from
Aug 26, 2022
Merged

[#61] Add GitHub add-on #97

merged 10 commits into from
Aug 26, 2022

Conversation

hoangmirs
Copy link
Collaborator

@hoangmirs hoangmirs commented Aug 9, 2022 •
edited
Loading

What happened 👀

  • Create GitHub addon:
    • Add GitHub templates
    • Add lint workflow
    • Create .gitignore from this template

Insight 📝

  • As dotfiles are not shown by default from glob.sync, I need to add the option dot: true
  • Add toBeEmpty matcher to test if the folder is empty

Proof Of Work 📹

Tests should be passed

2022-08-09 09 42 11

nimble-test
├── .github
│   ├── ISSUE_TEMPLATE
│   ├── PULL_REQUEST_TEMPLATE
│   ├── PULL_REQUEST_TEMPLATE.md
│   └── workflows
├── .gitignore
├── main.tf
├── modules
│   ├── alb
│   ├── bastion
│   ├── ecr
│   ├── ecs
│   ├── log
│   ├── rds
│   ├── s3
│   ├── security_group
│   ├── ssm
│   └── vpc
├── outputs.tf
├── providers.tf
└── variables.tf

@hoangmirs hoangmirs added the type : feature New feature or request label Aug 9, 2022
@hoangmirs hoangmirs added this to the 1.2.0 milestone Aug 9, 2022
@hoangmirs hoangmirs self-assigned this Aug 9, 2022
malparty
malparty approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last minor suggestion ⬆️
But the rest is awesome!! Thanks for having also cleaned the previous options (Heroku, etc...) 🙇 🙇 🙇 🙇

@hoangmirs hoangmirs mentioned this pull request Aug 9, 2022
Open
longnd
longnd reviewed Aug 16, 2022
View reviewed changes
skeleton/github/.github/PULL_REQUEST_TEMPLATE.md Outdated
@@ -0,0 +1,13 @@
- Close #
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use the new PR template https://github.com/nimblehq/git-template/pull/27/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let update the content descriptions but keep the - Close # (as there is a PR in progress) ;-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed in f3a5013

skeleton/github/.github/PULL_REQUEST_TEMPLATE/release_template.md Outdated
Comment on lines 7 to 11
Provide the ID and title of the issue in the section for each type (feature, chore and bug). The link is optional.

- [sc-1234] As a user, I can log in
or just
- [[sc-1234](https://app.shortcut.com/nimblehq/story/1234)] As a user, I can log in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match with the way we're currently doing

Suggested change
Provide the ID and title of the issue in the section for each type (feature, chore and bug). The link is optional.
- [sc-1234] As a user, I can log in
or just
- [[sc-1234](https://app.shortcut.com/nimblehq/story/1234)] As a user, I can log in
Provide the Pull Request IDs in the section for each type (feature, chore, and bug), e.g.
- #1234

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed in f3a5013

@hoangmirs
Copy link
Collaborator Author

@malparty @andyduong1920 I requested you to review this PR again as I changed a bit:

  1. Add None option for version control in case we don't use it
  2. Move skeleton/github into skeleton/addons/versionControl/github

Please help me take a look at that 🙏

malparty
malparty approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@hoangmirs hoangmirs merged commit 5c681a3 into develop Aug 26, 2022
@hoangmirs hoangmirs deleted the feature/61-github-addon branch August 26, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@longnd longnd longnd approved these changes

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@hanam1ni hanam1ni Awaiting requested review from hanam1ni

@junan junan Awaiting requested review from junan

@rosle rosle Awaiting requested review from rosle

@Nihisil Nihisil Awaiting requested review from Nihisil Nihisil is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@Lahphim Lahphim Awaiting requested review from Lahphim

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

Assignees

@hoangmirs hoangmirs

Labels
type : feature New feature or request
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Add GitHub add-on Add **/.terraform/** into the .gitignore file
4 participants
@hoangmirs @longnd @andyduong1920 @malparty