Fix: Can't generate the project #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangmirs
requested review from
andyduong1920,
byhbt,
hanam1ni,
longnd,
rosle,
Nihisil,
bterone,
Lahphim and
malparty
as code owners
bterone
approved these changes
Dec 26, 2022
byhbt
approved these changes
Dec 30, 2022
andyduong1920
approved these changes
Dec 30, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@nimblehq/infra-template", | |||
| "version": "1.2.0", | |||
| "version": "1.4.0", | |||
There was a problem hiding this comment.
1.3.0 was the last release. I did not change it, then I had to release it manually
nvminhtue
approved these changes
Dec 30, 2022
Fix: No .gitignore file in the generated project
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
NODE_ENV=productionfor the command, then it failed to get the correctskeletonpath. So we just need to set that in thebin/run1.4.0for the next releaseInsight 📝
N/A
Proof Of Work 📹
You can test with the version
@nimblehq/[email protected]