Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unexpected_input being passed to actions/download-artifact@v3 #447

Closed
vnntsu opened this issue Jul 26, 2023 · 1 comment · Fixed by #453
Closed

Remove unexpected_input being passed to actions/download-artifact@v3 #447

vnntsu opened this issue Jul 26, 2023 · 1 comment · Fixed by #453
Assignees

Comments

@vnntsu
Copy link

vnntsu commented Jul 26, 2023

Why

On the generated project, when test.yml runs at step Run Danger, we can see a warning as the following screenshot:

image

The warning says we are passing unexpected inputs to the download artifact. In our codebase, we are passing three such inputs - github_token, workflow, and workflow_conclusion in the following lines.

In order to avoid warnings caused by these unexpected inputs, we can remove them.

Who Benefits?

@nimblehq/web-chapter

@Goose97
Copy link
Contributor

Goose97 commented Jul 26, 2023

+1 on this warning

In my case, the step also errors with this:
image

My guess is:

  1. On the first run, we don't have any test cases, so no coverage info is generated. I tested again in my local machine, the behavior is the same
  2. The upload step finds no files and moves on
  3. There's no files to download --> it errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants