Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRUD] Add the form view templates to the generator #493

Closed
malparty opened this issue Dec 19, 2023 · 0 comments · Fixed by #506
Closed

[CRUD] Add the form view templates to the generator #493

malparty opened this issue Dec 19, 2023 · 0 comments · Fixed by #506
Assignees
@khangbui22
Labels
type : feature

Comments

@malparty
Copy link
Member

Why

The default view generator in Rails does not include Bootstrap classes and has a poor layout. To make the generator usable out of the box, the Rails template must ship with custom view templates.

  • This story only focuses on the new, create, edit and update views.
  • Ensure the template is using the SLIM engine
  • Ensure the show view is not generated.

Who Benefits?

Greenfield project teams.
@khangbui22 khangbui22 self-assigned this Jan 11, 2024
khangbui22 added a commit that referenced this issue Mar 13, 2024
@khangbui22
[#493] Add slim view templates for new, form, and edit
5eab66e
@khangbui22 khangbui22 mentioned this issue Mar 13, 2024
Merged
2 tasks
khangbui22 added a commit that referenced this issue Mar 13, 2024
@khangbui22
[#493] Fix view error
7f2273c
khangbui22 added a commit that referenced this issue Mar 13, 2024
@khangbui22
[#493] Add slim view templates for new, form, and edit
552b9c2
khangbui22 added a commit that referenced this issue Mar 13, 2024
@khangbui22
[#493] Fix view error
9484434
github-merge-queue bot pushed a commit that referenced this issue Apr 9, 2024
@khangbui22 @malparty
[#493][CRUD] Add the form view templates to the generator (#506)
a63ef25 
* [#483] Add tests to the CRUD layout

* [#483] Fix the check for slim and erb layout files

* [#493] Add slim view templates for new, form, and edit

* [#493] Fix view error

---------

Co-authored-by: Xavier MALPARTY <[email protected]>
@malparty malparty mentioned this issue Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khangbui22 khangbui22

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#493][CRUD] Add the form view templates to the generator nimblehq/rails-templates
2 participants
@khangbui22 @malparty