Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#493][CRUD] Add the form view templates to the generator #506

Merged

Conversation

khangbui22
Copy link
Contributor

What happened 👀

  • Add new, edit and _form view template
  • Tests passed

Insight 📝

This PR only focuses on the new, edit, and form view templates

Proof Of Work 📹

Screen.Recording.2024-03-13.at.09.09.52.mov

@khangbui22 khangbui22 changed the base branch from develop to feature/gh492-crud-addon-index-view-template March 13, 2024 02:11
@khangbui22 khangbui22 self-assigned this Mar 13, 2024
@khangbui22 khangbui22 added this to the 5.13.0 milestone Mar 13, 2024
@khangbui22 khangbui22 changed the title [#492][CRUD] Add the form view templates to the generator [#493][CRUD] Add the form view templates to the generator Mar 13, 2024
@khangbui22 khangbui22 marked this pull request as ready for review March 13, 2024 02:20
@khangbui22 khangbui22 requested a review from a user March 13, 2024 02:20
@khangbui22 khangbui22 requested a review from sanG-github as a code owner March 13, 2024 02:20
Base automatically changed from feature/gh492-crud-addon-index-view-template to develop March 13, 2024 10:01
@khangbui22 khangbui22 force-pushed the feature/gh493-crud-addon-new-edit-form-view-templates branch from 7f2273c to 9484434 Compare March 13, 2024 10:06
@malparty malparty modified the milestones: 5.13.0, 5.14.0 Mar 14, 2024
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Sorry for the review delay 🙇

@malparty malparty added this pull request to the merge queue Apr 9, 2024
Merged via the queue into develop with commit a63ef25 Apr 9, 2024
5 checks passed
@malparty malparty deleted the feature/gh493-crud-addon-new-edit-form-view-templates branch April 9, 2024 06:08
@malparty malparty mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRUD] Add the form view templates to the generator
3 participants