Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#340] Update Git Template for Pull Request #341

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[#340] Update Git Template for Pull Request #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
## What happened
https://github.com/nimblehq/rails-templates/issues/??

Describe the big picture of your changes here to communicate to the team why we should accept this pull request.
## What happened 👀

## Insight
Provide a description of the **changes** this pull request brings to the codebase. Additionally, when the pull request is still being worked on, a checklist of the planned changes is welcome to track progress.

Describe in details how to test the changes. Referenced documentation are welcome as well.
## Insight 📝

## Proof Of Work
Describe in detail why this solution is the most appropriate, which solution you tried but did not go with, and how to test the changes. References to relevant documentation are welcome as well.

Show us the implementation: screenshots, gif, etc.
## Proof Of Work 📹

Show us the implementation: screenshots, GIFs, etc.
12 changes: 6 additions & 6 deletions .template/addons/github/.github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
Add the story URL here. Prefer the short link format, e.g. https://app.clubhouse.io/acme/story/1234/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, should we change app.clubhouse.io to app.shortcut.com :D


## What happened
## What happened 👀

Describe the big picture of your changes here to communicate to the team why we should accept this pull request.
Provide a description of the **changes** this pull request brings to the codebase. Additionally, when the pull request is still being worked on, a checklist of the planned changes is welcome to track progress.

## Insight
## Insight 📝

Describe in detail how to test the changes. Referenced documentation is welcome as well.
Describe in detail why this solution is the most appropriate, which solution you tried but did not go with, and how to test the changes. References to relevant documentation are welcome as well.

## Proof Of Work
## Proof Of Work 📹

Show us the implementation: screenshots, gif, etc.
Show us the implementation: screenshots, GIFs, etc.