Fix reward inherent hashes #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibhar
approved these changes
May 16, 2024
sisou
reviewed
May 16, 2024
Comment on lines
-661
to
+667
| validator_address, | ||
| reward_address, | ||
| ref validator_address, | ||
| ref reward_address, | ||
| value, | ||
| }) => Inherent::Reward { | ||
| block_number: hist_tx.block_number, | ||
| block_time: hist_tx.block_time, | ||
| validator_address, | ||
| target: reward_address, | ||
| validator_address: validator_address.clone(), | ||
| target: reward_address.clone(), |
There was a problem hiding this comment.
Why is cloning better than using ref?
There was a problem hiding this comment.
Wanted to move the .tx_hash() into the branch, but that requires the full object without moving stuff out. Since Address is just 20 bytes, cloning doesn't do much work here anyway.
jsdanielh
approved these changes
May 17, 2024
jsdanielh
force-pushed
the
hrxi/reward_inherent_hash
branch
from
e273640 to
386c4f5
Compare
The wrong hash function was used, instead `tx_hash` is correct. Fixes #2408.
jsdanielh
force-pushed
the
hrxi/reward_inherent_hash
branch
from
386c4f5 to
d1e17ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong hash function was used, instead
tx_hashis correct.Fixes #2408.