Test aggregates more #344
Merged
Test aggregates more #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't change behavior.
This currently fails!
Ericson2314
force-pushed
the
test-aggregates-more
branch
from
5b1a824 to
e3ec0aa
Compare
Mic92
reviewed
Dec 9, 2024
| @@ -147,6 +157,10 @@ def absent_or_empty(f: str, d: dict) -> bool: | |||
| assert "error" not in indirect | |||
| assert "error" not in mixed | |||
|
|
|||
| check_gc_root(tempdir, direct["drvPath"]) | |||
Ericson2314
commented
Dec 9, 2024
| @@ -204,7 +204,7 @@ void worker( | |||
| /* Register the derivation as a GC root. !!! This | |||
| registers roots for jobs that we may have already | |||
| done. */ | |||
| if (args.gcRootsDir.empty()) { | |||
| if (!args.gcRootsDir.empty()) { | |||
There was a problem hiding this comment.
Fixed the bug :)
Condition got flipped in fd76732.
Mic92
force-pushed
the
test-aggregates-more
branch
from
3c7d5ea to
8ed334a
Compare
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ma27 I minimized the bug! But I am trouble figuring out why it is happening.