Manual tagging of files

aince42 · 2025-01-07T09:20:39Z

Readiness checklist

I added/updated tests.
I ensured that the PR title is good enough for the changelog.
I labeled the PR.
I self-reviewed the PR.

The following is currently possible

Loading tag collections from assets
Manual tagging of files
Editing and deleting tags
Display tags in the FileScreen

Still needs to be implemented

Tags of files where I am not the owner can not be edited/changed
If the last link in a tag chain has not been selected, it can still be succeeded
If a tag chain already exists and it is deleted, the tag container should be displayed again (An empty list should be treated in exactly the same way as a null value)
UI must be adapted as soon as Figma has been updated

Below you can see screenshots of the currently implemented UI.

It doesn't look good, especially with longer tags.

Siolto · 2025-01-07T10:46:21Z

Could you please also add, what is still open after this PR.

Siolto · 2025-01-08T09:11:12Z

Remove the second input field in the upload file bottom sheet. This was a temporary solution

Siolto · 2025-01-08T09:12:16Z

while uploading a file I get a error about the tagCollection:

════════ Exception caught by widgets library ═══════════════════════════════════
LateInitializationError: Field '_tagCollection@3348467827' has not been initialized.
The relevant error-causing widget was:
    FileDetailScreen FileDetailScreen:file:///Users/simoncoen/Projekte/enmeshed/app/apps/enmeshed/lib/main.dart:335:32

apps/enmeshed/lib/account/my_data/file/modals/edit_file.dart

Siolto · 2025-01-08T09:23:07Z

apps/enmeshed/lib/account/my_data/file/utils/get_tag_label.dart

+    return displayNames[currentLocale]!;
+  }
+
+  return displayNames['en']!;


probably a comment is helpful that 'en' is always the fallback

Siolto · 2025-01-08T09:24:45Z

apps/enmeshed/lib/account/my_data/file/files_screen.dart

@@ -127,6 +127,7 @@ class _FilesScreenState extends State<FilesScreen> {
                    accountId: widget.accountId,
                    fileRecord: _filteredFileRecords[index],
                    trailing: const Icon(Icons.chevron_right),
+                    reload: _loadFiles,


why do we need the reload again?

why do we need the reload again?

So that the FilesScreen is also updated as soon as an update has been made to the file.
If you navigate back and then click on the file again, the “fileReferenceAttribute” is passed directly from the FilesScreen.
If this is not up-to-date, the current tags are not displayed in the FileDetailScreen either.

Siolto

second input field in file upload sheet is still there

Siolto · 2025-01-09T09:16:20Z

apps/enmeshed/lib/account/my_data/file/modals/edit_file.dart

+            ],
+          ),
+        ),
+        if (_loading) const ModalLoadingOverlay(text: 'Dokument wird gespeichert...', isDialog: false),


translation

Siolto · 2025-01-09T09:19:20Z

apps/enmeshed/lib/account/my_data/file/file_detail_screen.dart

    _tags = widget.fileReferenceAttribute?.tags;

-    if (_fileDVO == null) _load();
+    _load();


why always load?

apps/enmeshed/lib/account/my_data/file/file_detail_screen.dart

Siolto · 2025-01-09T09:26:53Z

apps/enmeshed/lib/account/my_data/file/widgets/file_tags_container.dart

+
+  @override
+  Widget build(BuildContext context) {
+    if (tags == null) {


do this check in the file details screen. When there are no tags just display this controller, otherwise display the selected tags

Siolto · 2025-01-09T09:49:34Z

apps/enmeshed/lib/account/my_data/file/widgets/available_tags_section.dart

+    if (selectedTags.isEmpty) return (tagsMap: currentLevel, currentPath: '');
+
+    var currentPath = '';
+    for (final tag in selectedTags) {


@aince42 I have simplified this logic. Please double check if it is still working as intended

jkoenig134 · 2025-01-23T14:14:23Z

I'll put this back to draft, as it is not matching the new design.

aince42 · 2025-01-27T12:34:53Z

This PR covers single-level tagging of files.
It is possible to assign multiple tags and edit them.

jkoenig134 · 2025-02-03T15:16:38Z

apps/enmeshed/lib/account/my_data/file/file_detail_screen.dart

+  late FileDVO? _fileDVO;
+  late LocalAttributeDVO? _fileReferenceAttribute;


late and ? is a VERY bad combination. Please explain here why you have chosen that.

late and ? is a VERY bad combination. Please explain here why you have chosen that.

You are right, in this case it is useless and causes confusion.

- fix: import - chore: add spacing to row - chore: early return

aince42 added 7 commits January 7, 2025 10:01

chore: update pubspec

a2cf390

chore: add translations

44985e4

chore: add example for tag collections

5c4791a

chore: reload files on pop

d8cc59e

refactor: outsource file infos

a96d0d1

feat: implement tagging and updating of tags

9b012a2

chore: update file detail screen

781ce74

aince42 added the enhancement New feature or request label Jan 7, 2025

aince42 requested review from Siolto, jkoenig134 and nicole-eb January 7, 2025 10:43

aince42 added 2 commits January 7, 2025 17:03

Merge branch 'main' into manual-tagging-of-files

3e8c72a

fix: linter errors

a8f5c0f

Siolto reviewed Jan 8, 2025

View reviewed changes

aince42 added 4 commits January 8, 2025 10:44

fix: missing translations

c9068d6

fix: error on add new file

5a1fb05

chore: add comment for fallback

8d0e579

fix: late initialization error

dc67a5c

aince42 requested a review from Siolto January 8, 2025 14:10

Siolto requested changes Jan 9, 2025

View reviewed changes

refactor: simplify _getAvailableTagsData()

b9b75dd

Siolto reviewed Jan 9, 2025

View reviewed changes

aince42 and others added 5 commits January 15, 2025 13:26

Merge branch 'main' into manual-tagging-of-files

3dc57f8

Merge branch 'tagging-of-files' into manual-tagging-of-files

9790a03

fix: add missing translation

2996d20

chore: update dependencies

8b0cbc7

chore: remove unused textfield

72fdae2

chore: make check in file detail screen

a25c1c9

jkoenig134 removed request for jkoenig134 and nicole-eb January 23, 2025 14:14

jkoenig134 marked this pull request as draft January 23, 2025 14:14

aince42 added 6 commits January 24, 2025 09:47

Merge remote-tracking branch 'origin/main' into manual-tagging-of-files

eb30eed

fix: imports

1988aa6

chore: update tagCollection to single level tags example

45b5c06

chore: update translations

4c5422e

chore: update assets path

5868982

chore: update ui and logic for dispaying and editing tags

3a94ea9

aince42 requested a review from Siolto January 27, 2025 08:40

aince42 marked this pull request as ready for review January 27, 2025 08:40

aince42 requested review from jkoenig134 and nicole-eb January 27, 2025 12:32

chore: use real tag collection data

a66bb9a

aince42 changed the title ~~Manual tagging of files~~ Manual tagging of files – single-level tags Feb 3, 2025

jkoenig134 and others added 3 commits February 3, 2025 16:08

chore: unfo lockfile changes

2ebbb8d

Merge branch 'tagging-of-files' into manual-tagging-of-files

a7bc731

Merge branch 'tagging-of-files' into manual-tagging-of-files

97c935c

jkoenig134 reviewed Feb 3, 2025

View reviewed changes

aince42 added 5 commits February 3, 2025 16:37

refactor: remove useless late initializations

09aa81c

refactor: add barrel export

01de942

chore: update FileDetailScreen

2adcc35

- fix: import - chore: add spacing to row - chore: early return

refactor: make one line

a3c52c3

refactor: add _LoadingIndicator

8c3b5f4

aince42 requested a review from jkoenig134 February 4, 2025 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manual tagging of files – single-level tags #377

Manual tagging of files – single-level tags #377

aince42 commented Jan 7, 2025 •

edited

Loading

Siolto commented Jan 7, 2025

Siolto commented Jan 8, 2025

Siolto commented Jan 8, 2025

Siolto Jan 8, 2025

Siolto Jan 8, 2025

aince42 Jan 8, 2025

Siolto left a comment

Siolto Jan 9, 2025

Siolto Jan 9, 2025

Siolto Jan 9, 2025 •

edited

Loading

Siolto Jan 9, 2025

jkoenig134 commented Jan 23, 2025

aince42 commented Jan 27, 2025

jkoenig134 Feb 3, 2025

aince42 Feb 3, 2025

		late FileDVO? _fileDVO;
		late LocalAttributeDVO? _fileReferenceAttribute;

Manual tagging of files – single-level tags #377

Are you sure you want to change the base?

Manual tagging of files – single-level tags #377

Conversation

aince42 commented Jan 7, 2025 • edited Loading

Readiness checklist

Manual tagging of files

The following is currently possible

Still needs to be implemented

Below you can see screenshots of the currently implemented UI.

It doesn't look good, especially with longer tags.

Siolto commented Jan 7, 2025

Siolto commented Jan 8, 2025

Siolto commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Siolto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Siolto Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jkoenig134 commented Jan 23, 2025

aince42 commented Jan 27, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aince42 commented Jan 7, 2025 •

edited

Loading

Siolto Jan 9, 2025 •

edited

Loading