Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual tagging of files – single-level tags #377
base: tagging-of-files
Are you sure you want to change the base?
Manual tagging of files – single-level tags #377
Changes from 9 commits
a2cf390
44985e4
5c4791a
d8cc59e
a96d0d1
9b012a2
781ce74
3e8c72a
a8f5c0f
c9068d6
5a1fb05
8d0e579
dc67a5c
b9b75dd
3dc57f8
9790a03
2996d20
8b0cbc7
72fdae2
a25c1c9
eb30eed
1988aa6
45b5c06
4c5422e
5868982
3a94ea9
a66bb9a
2ebbb8d
a7bc731
97c935c
09aa81c
01de942
2adcc35
a3c52c3
8c3b5f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
late and ? is a VERY bad combination. Please explain here why you have chosen that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, in this case it is useless and causes confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why always load?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need the reload again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that the FilesScreen is also updated as soon as an update has been made to the file.
If you navigate back and then click on the file again, the “fileReferenceAttribute” is passed directly from the FilesScreen.
If this is not up-to-date, the current tags are not displayed in the FileDetailScreen either.