Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROS1/CMake] Modify CMake scripts to support catkin_make #48

Merged
merged 1 commit into from
Oct 22, 2020
Merged

[ROS1/CMake] Modify CMake scripts to support catkin_make #48

merged 1 commit into from
Oct 22, 2020

Conversation

wooksong
Copy link
Member

@wooksong wooksong commented Oct 22, 2020 •
edited
Loading

Related to nnstreamer/nnstreamer#2728

This patch modifies the CMake script files for ROS1 to support catkin_make.

Signed-off-by: Wook Song [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #48. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/48-202010221002320.75635695457458-dfb233617a0d94b706125c4ef2ac051d91745f98/report/misspelling_result.txt.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/48-202010221002320.75635695457458-dfb233617a0d94b706125c4ef2ac051d91745f98/.

@wooksong
[ROS1/CMake] Modify CMake scripts to support catkin_make
c2f6dbc 
This patch modifies the CMake script files for ROS1 to support
catkin_make.

Signed-off-by: Wook Song <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/48-202010221017350.61401104927063-c2f6dbca7cecb769139424f5e435bb51ea1880d6/report/misspelling_result.txt.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2020

:octocat: cibot: @wooksong, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nnstreamer-ros/ci/repo-workers/pr-checker/48-202010221017350.61401104927063-c2f6dbca7cecb769139424f5e435bb51ea1880d6/.

myungjoo
myungjoo approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@myungjoo myungjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myungjoo myungjoo merged commit 638e6cc into nnstreamer:main Oct 22, 2020
@wooksong wooksong linked an issue Nov 3, 2020 that may be closed by this pull request
ROS2 Support #38
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROS2 Support
3 participants
@wooksong @taos-ci @myungjoo