Failures after V8 5.4 update on master #187
Comments
|
Related: #179 I'm pretty sure this is because we have to update |
|
Is there a Travis build I can look at? |
|
Here is a citgm run with a forced rebuild
/cc @jasnell can you do an updated release of v7 with the NODE_MODULE_VERSION bumped? edit: lolol no node-gyp... one more time https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/397/ |
|
https://ci.nodejs.org is currently 502'ing. I'll keep an eye on it. |
|
@thealphanerd sorry, I'm failing to find the node-sass build log. |
|
bah... the rebuild job is not working in the regular CI job... made a custom CI job for rebuild, this should hopefully work https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-rebuild/2/ |
|
|
@thealphanerd is there a link to the build? |
|
Yep. The hope is to get that updated build today. On Monday, September 26, 2016, Myles Borins [email protected]
|
|
Why doesn't the regular job rebuild? Seems like the right thing to do. On Tue, Sep 27, 2016, 8:47 AM James M Snell [email protected]
|
|
Looking at the node-sass failures, it appears to be because the pre-built binary isn't compatible anymore. I'm guessing this is because the ABI changed but the module version didn't? As for why it's erring the way it is, there looks to be a problem with our install script. After pulling down a prebuilt binary we https://github.com/sass/node-sass/blob/master/scripts/build.js#L208-L218 |
|
Because of the wired state the abi gets in (eg not bumped when it has Forcing a compile will catch incompatibilities with newer versions of node On Tue, Sep 27, 2016, 9:52 AM Michael Mifsud [email protected]
|
|
so it seems like the rebuild job is never getting to the "rebuild" lifecycle stage on As for why rebuild is not the standard approach... we want to actually catch things breaking as people would normally use npm, we can then use rebuild as a follow up for deeper diving. totally open to reviewing that process. |
|
I agree with you, I think getting the ABI version bumped as soon as it's broken is a good thing. =) I also think your current process is 👍 |
|
I've submitted a PR that bumps the NODE_MODULE_VERSION on master. This should |
|
node-sass tests are passing with the latest OSX nightly (node-v7.0.0-nightly201609276b443d1731-darwin-x64). |
|
We've landed the bump to NODE_MODULE_VERSION New ci to see what's up |
|
node-sass failed: |
As of [email protected] `npm test` can now be run from the published tarball. The node-sass failure seen in nodejs#187 (comment) is due to using master. In order to compile node-sass from git the `src/libsass` submodule needs to be fetched. The missing submodule is causing node-gyp to fail because it can't the LibSass sources files. ```sh make: *** No rule to make target 'Release/obj.target/libsass/src/libsass/src/ast.o', needed by 'Release/obj.target/src/sass.a'. Stop. ``` The LibSass source is published to npm so node-gyp will _just work_.
|
Sorry y'all it took me a good to while to figure out what's going here with node-sass. The issue stems from node-sass being installed from github rather than the npm. The github repo git submodules in LibSass. Since the submodule isn't being fetched CI, make is failing to find the LibSass sources files. I spent some time today getting node-sass into a state where the npm package is compatible with node-citgm. I've have just published [email protected]. I have also opened #188 to remove the |
As of [email protected] `npm test` can now be run from the published tarball. The node-sass failure seen in nodejs#187 are due to using master. In order to compile node-sass from git the `src/libsass` submodule needs to be fetched. The missing submodule is causing node-gyp to fail because it can't find the LibSass sources files. ```sh make: *** No rule to make target 'Release/obj.target/libsass/src/libsass/src/ast.o', needed by 'Release/obj.target/src/sass.a'. Stop. ``` The LibSass source is published to npm so node-gyp will _just work_.
As of [email protected] `npm test` can now be run from the published tarball. The node-sass failure seen in #187 are due to using master. In order to compile node-sass from git the `src/libsass` submodule needs to be fetched. The missing submodule is causing node-gyp to fail because it can't find the LibSass sources files. ```sh make: *** No rule to make target 'Release/obj.target/libsass/src/libsass/src/ast.o', needed by 'Release/obj.target/src/sass.a'. Stop. ``` The LibSass source is published to npm so node-gyp will _just work_.
Looks like three failures have we:
/cc @ralphtheninja @reconbot @xzyfer
The text was updated successfully, but these errors were encountered: