Use latest dist-tag for node-sass

[xzyfer]

As of [email protected] npm test can now be run from the published
tarball.

The node-sass failure seen in #187 are due to using master. In order to
compile node-sass from git the src/libsass submodule needs to be fetched.
The missing submodule is causing node-gyp to fail because it can't find the
LibSass sources files.

make: *** No rule to make target 'Release/obj.target/libsass/src/libsass/src/ast.o', needed by 'Release/obj.target/src/sass.a'.  Stop.

The LibSass source is published to npm so node-gyp will just work.

[MylesBorins]

@xzyfer our algorithm is always using the release tarballs from github, not the published repo from npm.

I've gone ahead and testing this locally and am still getting errors.

warn:    npm-install:        | dyld: lazy symbol binding failed: Symbol not found: __ZN2v816FunctionTe
warn:                        | Referenced from: /private/var/folders/ty/q7q6b07j5r3c7nvnpzm6hkq40000gn/T/572e1
warn:                        | Expected in: flat namespace
warn:                        |
warn:                        | dyld: Symbol not found: __ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20Fu
warn:                        | Referenced from: /private/var/folders/ty/q7q6b07j5r3c7nvnpzm6hkq40000gn/T/572e1
warn:                        | Expected in: flat namespace
info:    npm:                | install successfully completed
info:    npm:                | test suite started
verbose: npm-test:           | > [email protected] test /private/var/folders/ty/q7q6b07j5r3c7nvnpzm6hkq
verbose:                     | > mocha test
verbose: npm-test:           | dyld: lazy symbol binding failed: Symbol not found: __ZN2v816FunctionTe
verbose:                     | Referenced from: /private/var/folders/ty/q7q6b07j5r3c7nvnpzm6hkq40000gn/T/572e1
verbose:                     | Expected in: flat namespace
verbose:                     |
verbose:                     | dyld: Symbol not found: __ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20Fu
verbose:                     | Referenced from: /private/var/folders/ty/q7q6b07j5r3c7nvnpzm6hkq40000gn/T/572e1
verbose:                     | Expected in: flat namespace

can you test locally and see what is going on to get this working on v7?

[MylesBorins]

I'm going to go ahead and land this as is, but adding a flaky label for v7, we should continue to investigate why it is broken

[MylesBorins]

landed in a55bf38

edit: this was landed with the prefix included and with flaky set for v7.

[xzyfer]

I've just jumped into bed. I was able to compile and run specs from the npm
tarball for 3.10.1 using the latest nightly on osx.

The error you've shown above suggests a breaking abi change has occurred
and our precompiled binary is incompatible. I was only able to reproduce
this error using a node 7 night from before the module version bump.

On 1 Oct 2016 1:36 AM, "Myles Borins" [email protected] wrote:

Closed #188 #188.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#188 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAjZWAUIwc-vOnybUHSAb_xYMjdcNOk6ks5qvSyWgaJpZM4KKxQB
.

[xzyfer]

I was under the impression from our previous discussions that citgm used
latest dist-tag from npm by default. Am I mistaken?

On 1 Oct 2016 2:39 AM, "Michael Mifsud" [email protected] wrote:

I've just jumped into bed. I was able to compile and run specs from the npm
tarball for 3.10.1 using the latest nightly on osx.

The error you've shown above suggests a breaking abi change has occurred
and our precompiled binary is incompatible. I was only able to reproduce
this error using a node 7 night from before the module version bump.

On 1 Oct 2016 1:36 AM, "Myles Borins" [email protected] wrote:

Closed #188 #188.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#188 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAjZWAUIwc-vOnybUHSAb_xYMjdcNOk6ks5qvSyWgaJpZM4KKxQB
.

[MylesBorins]

@xzyfer let's co-ordinate some time next week to pair on this. Feel free to email me or drop in dms to find a time

[MylesBorins]

@xzyfer every module in citgm is being tested based on a tarball published to github. in the lookup table "replace" is telling citgm to grab the tarball from github instead of npm. We are using dist-tag to get the version we want to grab.

I'd be open to discussing using the npm package... we have in general found the published tarball to be more reliable. (Also probably good for people to be able to run the test suite on published tar ball on github)