fs: mkdtemp should not fail if no callback passed #6828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefourtheye
added
the
fs
thefourtheye
force-pushed
the
fix-fs-mkdtemp-callback
branch
from
8235c32 to
66a5666
Compare
|
LGTM. On an unrelated note, how about moving the |
|
LGTM if CI is green |
thefourtheye
force-pushed
the
fix-fs-mkdtemp-callback
branch
3 times, most recently
from
49a7016 to
b50654d
Compare
|
@mscdex I moved them and changed |
|
@thefourtheye Looks better now. However you might make the code move a separate commit so that the callback change is more easily visible. |
thefourtheye
force-pushed
the
fix-fs-mkdtemp-callback
branch
from
b50654d to
0a87d37
Compare
|
@mscdex Oh yes. This is better now. Thanks :-) PTAL. |
| @@ -2000,7 +2000,8 @@ SyncWriteStream.prototype.destroy = function() { | |||
|
|
|||
| SyncWriteStream.prototype.destroySoon = SyncWriteStream.prototype.destroy; | |||
|
|
|||
| fs.mkdtemp = function(prefix, options, callback) { | |||
| fs.mkdtemp = function(prefix, options, callback_) { | |||
| let callback = maybeCallback(callback_); | |||
There was a problem hiding this comment.
minor nit: might change this to var callback to be consistent with the rest of fs. Also let in general is still slow IIRC, although whether that will matter in the grand scheme of things in this particular case is hard to say.
There was a problem hiding this comment.
@mscdex Sorry, I made a big mess out of this small change. PTAL now. I updated.
As it is, `fs.mkdtemp` crashes with a C++ assertion if the callback function is not passed. This patch uses `maybeCallback` to create one, if no callback function is passed.
thefourtheye
force-pushed
the
fix-fs-mkdtemp-callback
branch
from
0a87d37 to
daa3750
Compare
|
CI again just to be safe: https://ci.nodejs.org/job/node-test-pull-request/2690/ |
jasnell
pushed a commit
that referenced
this pull request
May 20, 2016
As it is, `fs.mkdtemp` crashes with a C++ assertion if the callback function is not passed. This patch uses `maybeCallback` to create one, if no callback function is passed. PR-URL: #6828 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 20, 2016
PR-URL: #6828 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
May 23, 2016
As it is, `fs.mkdtemp` crashes with a C++ assertion if the callback function is not passed. This patch uses `maybeCallback` to create one, if no callback function is passed. PR-URL: #6828 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
May 23, 2016
PR-URL: #6828 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
As it is, `fs.mkdtemp` crashes with a C++ assertion if the callback function is not passed. This patch uses `maybeCallback` to create one, if no callback function is passed. PR-URL: #6828 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
PR-URL: #6828 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
fs
Description of change
As it is,
fs.mkdtempcrashes with a C++ assertion if the callbackfunction is not passed. This patch uses
maybeCallbackto create one,if no callback function is passed.