fs: execute mkdtemp's callback with no context #7068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefourtheye
added
the
fs
| fs.mkdtemp(path.join(common.tmpDir, 'bar.'), common.mustCall(handler)); | ||
|
|
||
| // Same test as above, but making sure that passing an options object doesn't | ||
| // affect the way callback function is handled. |
There was a problem hiding this comment.
nit: affect the way the callback?
|
Thanks for the review @addaleax :-) I am not a native English speaker, so thanks for correcting my punctuations and grammar :-) Updated. PTAL |
|
no problem :) LGTM! |
|
Bump! |
| @@ -1616,7 +1615,7 @@ fs.mkdtemp = function(prefix, options, callback_) { | |||
| } | |||
|
|
|||
| var req = new FSReqWrap(); | |||
| req.oncomplete = callback; | |||
| req.oncomplete = makeCallback(callback); | |||
There was a problem hiding this comment.
Does makeCallback() need to be called earlier? What if callback is invoked via nullCheck() a few lines up?
There was a problem hiding this comment.
Oh yes. Fixed it now. PTAL.
All the callback functions in `fs` module are supposed to be executed
with no context (`this` value should not be a valid object). But
`mkdtemp`'s callback will have the `FSReqWrap` object as the context.
Sample code to reproduce the problem
'use strict';
const fs = require('fs');
fs.mkdtemp('/tmp/abcd', null, function() {
console.log(this);
});
This would print
FSReqWrap { oncomplete: [Function] }
But that should have printed `null` and this patch fixes that.
thefourtheye
force-pushed
the
fix-mkdtemp-cb-global-scope
branch
from
d1647f9 to
7ea5025
Compare
|
LGTM |
1 similar comment
|
LGTM |
|
Landed in c4fadbc |
thefourtheye
added a commit
that referenced
this pull request
Jun 4, 2016
All the callback functions in `fs` module are supposed to be executed
with no context (`this` value should not be a valid object). But
`mkdtemp`'s callback will have the `FSReqWrap` object as the context.
Sample code to reproduce the problem
'use strict';
const fs = require('fs');
fs.mkdtemp('/tmp/abcd', null, function() {
console.log(this);
});
This would print
FSReqWrap { oncomplete: [Function] }
But that should have printed `null` and this patch fixes that.
PR-URL: #7068
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
2 tasks
evanlucas
pushed a commit
that referenced
this pull request
Jun 15, 2016
All the callback functions in `fs` module are supposed to be executed
with no context (`this` value should not be a valid object). But
`mkdtemp`'s callback will have the `FSReqWrap` object as the context.
Sample code to reproduce the problem
'use strict';
const fs = require('fs');
fs.mkdtemp('/tmp/abcd', null, function() {
console.log(this);
});
This would print
FSReqWrap { oncomplete: [Function] }
But that should have printed `null` and this patch fixes that.
PR-URL: #7068
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Merged
|
@thefourtheye lts? |
|
@thealphanerd I am afraid #6828, #6832, and #6834 are also necessary. |
|
marking as don't land as the other mentioned pr's are as well. Please feel free to revisit as a backport PR if you think it is necessary for LTS stability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
fs
Description of change
All the callback functions in
fsmodule are supposed to be executedwith no context (
thisvalue should not be a valid object). Butmkdtemp's callback will have theFSReqWrapobject as the context.Sample code to reproduce the problem
This would print
But that should have printed
nulland this patch fixes that.cc @nodejs/fs
CI Run: https://ci.nodejs.org/job/node-test-pull-request/2865/