fix: incorrect http(s) regexp (#1212)

* fix: incorrect http(s) regexp * Add more test for requestBadPort
nodejs · Feb 8, 2022 · d94dc15 · d94dc15
1 parent 6bbc0b0
commit d94dc15
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/fetch/util.js b/lib/fetch/util.js
@@ -61,7 +61,7 @@ function requestBadPort (request) {
 
   // 2. If url’s scheme is an HTTP(S) scheme and url’s port is a bad port,
   // then return blocked.
-  if (/^http?s/.test(url.protocol) && badPorts.includes(url.port)) {
+  if (/^https?:/.test(url.protocol) && badPorts.includes(url.port)) {
     return 'blocked'
   }
 

diff --git a/test/fetch/util.js b/test/fetch/util.js
@@ -47,11 +47,14 @@ test('responseLocationURL', (t) => {
 })
 
 test('requestBadPort', (t) => {
-  t.plan(2)
+  t.plan(3)
 
   t.equal('allowed', util.requestBadPort({
     urlList: [new URL('https://asd')]
   }))
+  t.equal('blocked', util.requestBadPort({
+    urlList: [new URL('http://asd:7')]
+  }))
   t.equal('blocked', util.requestBadPort({
     urlList: [new URL('https://asd:7')]
   }))