fix: incorrect http(s) regexp #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1212 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 43 43
Lines 4035 4035
=======================================
Hits 3773 3773
Misses 262 262
Continue to review full report at Codecov.
|
ronag
approved these changes
Feb 8, 2022
|
Do you think you could add a regression test? |
I add more test for requestBadPort |
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix: incorrect http(s) regexp * Add more test for requestBadPort
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fix: incorrect http(s) regexp * Add more test for requestBadPort
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: incorrect http(s) regexp * Add more test for requestBadPort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/^http?s/is matched forhttsandhttps.It should fix to
/^https?:/(matched forhttp:andhttps:)