chore: box ParserErrors in InterpreterError
#7373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Looks good!
Is this noticeable somewhere? I'm asking mainly because I'm thinking of reviving #7147 : it's probably not noticeable in a big compilation, but it is faster (milliseconds faster) and that always helps if it's seen from an LSP perspective (where every millisecond matters).
|
That said... |
Oof I didn't see that. Will make a followup |
5 tasks
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 14, 2025
…oir-lang/noir#7393) chore: document traits required to be in scope (noir-lang/noir#7387) fix: field zero division in brillig (noir-lang/noir#7386) chore: box `ParserError`s in `InterpreterError` (noir-lang/noir#7373) chore: remove unnecessary dereferencing within brillig vm (noir-lang/noir#7375) fix: give "correct" error when trying to use AsTraitPath (noir-lang/noir#7360)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 14, 2025
…oir#7393) chore: document traits required to be in scope (noir-lang/noir#7387) fix: field zero division in brillig (noir-lang/noir#7386) chore: box `ParserError`s in `InterpreterError` (noir-lang/noir#7373) chore: remove unnecessary dereferencing within brillig vm (noir-lang/noir#7375) fix: give "correct" error when trying to use AsTraitPath (noir-lang/noir#7360)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 14, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(ssa): Do not deduplicate division by a zero constant (noir-lang/noir#7393) chore: document traits required to be in scope (noir-lang/noir#7387) fix: field zero division in brillig (noir-lang/noir#7386) chore: box `ParserError`s in `InterpreterError` (noir-lang/noir#7373) chore: remove unnecessary dereferencing within brillig vm (noir-lang/noir#7375) fix: give "correct" error when trying to use AsTraitPath (noir-lang/noir#7360) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>
TomAFrench
added a commit
that referenced
this pull request
Feb 14, 2025
…rom-brillig * master: chore: allow opting in to displaying benchmark comments (#7399) chore: box `ExprValue` in `Value` enum (#7388) chore: pull out refactored methods from u128 branch (#7385) feat: require safety comments instead of safety doc comments (#7295) fix(ssa): Do not deduplicate division by a zero constant (#7393) chore: document traits required to be in scope (#7387) fix: field zero division in brillig (#7386) chore: box `ParserError`s in `InterpreterError` (#7373) chore: remove unnecessary dereferencing within brillig vm (#7375) fix: give "correct" error when trying to use AsTraitPath (#7360) chore: avoid u128s in brillig memory (#7363) chore: update docs about integer overflows (#7370) fix!: Only decrement the counter of an array if its address has not changed (#7297) fix: let LSP read `noirfmt.toml` for formatting files (#7355) chore: deprecate keccak256 (#7361) feat: `FunctionDefinition::as_typed_expr` (#7358) feat(performance): Check sub operations against induction variables (#7356) chore: avoid doing all brillig integer arithmetic on u128s (#7357)
TomAFrench
added a commit
that referenced
this pull request
Feb 14, 2025
* master: chore: allow opting in to displaying benchmark comments (#7399) chore: box `ExprValue` in `Value` enum (#7388) chore: pull out refactored methods from u128 branch (#7385) feat: require safety comments instead of safety doc comments (#7295) fix(ssa): Do not deduplicate division by a zero constant (#7393) chore: document traits required to be in scope (#7387) fix: field zero division in brillig (#7386) chore: box `ParserError`s in `InterpreterError` (#7373) chore: remove unnecessary dereferencing within brillig vm (#7375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
InterpreterErroris currently 488 bytes (and so all ofIResultsare as well). Most of that size comes from it holding aParserErrorinside one of its variants so I've boxed that which reduces the size of anInterpreterErrorto 192 bytes.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.