Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: box ExprValue in Value enum #7388

Merged
merged 4 commits into from
Feb 14, 2025
Merged

chore: box ExprValue in Value enum #7388

merged 4 commits into from
Feb 14, 2025

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Followup to #7373

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from asterite February 14, 2025 15:10
@TomAFrench
Copy link
Member Author

This causes an appreciable drop in the test suite benchmarks.

@TomAFrench TomAFrench requested a review from a team February 14, 2025 17:59
@asterite
Copy link
Collaborator

Also doing nargo check --force in rollup-base-private goes from 0.6s to 0.5s

@asterite
Copy link
Collaborator

This causes an appreciable drop in the test suite benchmarks.

How do you check this? Do you manually check the times on the CI run?

@TomAFrench
Copy link
Member Author

I'm just looking in the github actions output when it's uploading the metrics: https://github.com/noir-lang/noir/actions/runs/13334702437/job/37247801035?pr=7388

I can then check against https://noir-lang.github.io/noir/dev/bench/ to see if they line up or not.

I think I can get the comments to show up if we apply a label to the PR however which will make this easier.

@TomAFrench TomAFrench added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit 30c4b2d Feb 14, 2025
103 checks passed
@TomAFrench TomAFrench deleted the tf/box-expr-value branch February 14, 2025 19:17
@TomAFrench TomAFrench mentioned this pull request Feb 14, 2025
Merged
5 tasks
@asterite asterite mentioned this pull request Feb 14, 2025
Merged
5 tasks
TomAFrench added a commit that referenced this pull request Feb 14, 2025
@TomAFrench
Merge branch 'master' into mv/duplicate-brillig-entry-points-called-f…
13e1dc3 
…rom-brillig

* master:
  chore: allow opting in to displaying benchmark comments (#7399)
  chore: box `ExprValue` in `Value` enum (#7388)
  chore: pull out refactored methods from u128 branch (#7385)
  feat: require safety comments instead of safety doc comments (#7295)
  fix(ssa): Do not deduplicate division by a zero constant (#7393)
  chore: document traits required to be in scope (#7387)
  fix: field zero division in brillig (#7386)
  chore: box `ParserError`s in `InterpreterError` (#7373)
  chore: remove unnecessary dereferencing within brillig vm (#7375)
  fix: give "correct" error when trying to use AsTraitPath (#7360)
  chore: avoid u128s in brillig memory (#7363)
  chore: update docs about integer overflows (#7370)
  fix!: Only decrement the counter of an array if its address has not changed (#7297)
  fix: let LSP read `noirfmt.toml` for formatting files (#7355)
  chore: deprecate keccak256 (#7361)
  feat: `FunctionDefinition::as_typed_expr` (#7358)
  feat(performance): Check sub operations against induction variables (#7356)
  chore: avoid doing all brillig integer arithmetic on u128s (#7357)
TomAFrench added a commit that referenced this pull request Feb 14, 2025
@TomAFrench
Merge branch 'master' into tf/u128-hacky
0486ab9 
* master:
  chore: allow opting in to displaying benchmark comments (#7399)
  chore: box `ExprValue` in `Value` enum (#7388)
  chore: pull out refactored methods from u128 branch (#7385)
  feat: require safety comments instead of safety doc comments (#7295)
  fix(ssa): Do not deduplicate division by a zero constant (#7393)
  chore: document traits required to be in scope (#7387)
  fix: field zero division in brillig (#7386)
  chore: box `ParserError`s in `InterpreterError` (#7373)
  chore: remove unnecessary dereferencing within brillig vm (#7375)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 15, 2025
@AztecBot
[1 changes] fix: format global attributes (noir-lang/noir#7401)
ede23df 
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
@AztecBot AztecBot mentioned this pull request Feb 15, 2025
Merged
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 16, 2025
@AztecBot
[1 changes] fix: format global attributes (noir-lang/noir#7401)
10a2f77 
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 16, 2025
@AztecBot
fix: format global attributes (noir-lang/noir#7401)
2faacd5 
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 17, 2025
@AztecBot
[1 changes] fix: format global attributes (noir-lang/noir#7401)
2ecd2a8 
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 17, 2025
@AztecBot
fix: format global attributes (noir-lang/noir#7401)
1bebc9f 
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch (noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 17, 2025
@AztecBot @TomAFrench
feat: Sync from noir (#12022)
ef462bb 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: format global attributes
(noir-lang/noir#7401)
chore: box `Closure` in `comptime::Value` enum
(noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments
(noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum
(noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch
(noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments
(noir-lang/noir#7295)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <[email protected]>
AztecBot added a commit to AztecProtocol/aztec-nr that referenced this pull request Feb 18, 2025
@AztecBot @TomAFrench
feat: Sync from noir (#12022)
c361ddd 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: format global attributes
(noir-lang/noir#7401)
chore: box `Closure` in `comptime::Value` enum
(noir-lang/noir#7400)
chore: allow opting in to displaying benchmark comments
(noir-lang/noir#7399)
chore: box `ExprValue` in `Value` enum
(noir-lang/noir#7388)
chore: pull out refactored methods from u128 branch
(noir-lang/noir#7385)
feat: require safety comments instead of safety doc comments
(noir-lang/noir#7295)
END_COMMIT_OVERRIDE

---------

Co-authored-by: Tom French <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @asterite