chore: box Closure in comptime::Value enum
#7400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: c0e2c09 | Previous: 30c4b2d | Ratio |
|---|---|---|---|
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
61 s |
48 s |
1.27 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 15, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 16, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 16, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 17, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 17, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 17, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: format global attributes (noir-lang/noir#7401) chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>
AztecBot
added a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Feb 18, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: format global attributes (noir-lang/noir#7401) chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Follow-up to #7388
Summary
This makes
Valuego from 280 to 152 bytes. Doingnargo checkonrollup-base-privateI notice a slight improvement, maybe not much but this is an easy change.Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.