Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove abi decoding from execute_program #868

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Feb 17, 2023

Related issue(s)

Resolves #

Description

Summary of changes

We only really make use of the decoded circuit return value which is returned from execute_program inside execute_cmd::run - in all other usages we just immediately drop it and just use the returned witness map.

This PR then moves the return value decoding up into execute_with_path and inlines solve_witness into execute_program.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@TomAFrench
Copy link
Member Author

I've erred on the side of keeping the execute_program name rather than solve_witness as I expect this is more understandable to new-to-ZK devs.

@kevaundray kevaundray added this pull request to the merge queue Feb 17, 2023
Merged via the queue into master with commit 5eddaf7 Feb 17, 2023
@kevaundray kevaundray deleted the remove-decode-from-execute branch February 17, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants