Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove abi decoding from execute_program #868

Merged
merged 2 commits into from
Feb 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/nargo/src/cli/compile_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ pub fn generate_circuit_and_witness_to_disk<P: AsRef<Path>>(
&compiled_program.abi,
)?;

let (_, solved_witness) =
super::execute_cmd::execute_program(&compiled_program, &inputs_map)?;
let solved_witness = super::execute_cmd::execute_program(&compiled_program, &inputs_map)?;

circuit_path.pop();
save_witness_to_dir(solved_witness, circuit_name, &circuit_path)?;
Expand Down
18 changes: 5 additions & 13 deletions crates/nargo/src/cli/execute_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,28 +64,20 @@ fn execute_with_path<P: AsRef<Path>>(
&compiled_program.abi,
)?;

execute_program(&compiled_program, &inputs_map)
}

pub(crate) fn execute_program(
compiled_program: &CompiledProgram,
inputs_map: &InputMap,
) -> Result<(Option<InputValue>, WitnessMap), CliError> {
// Solve the remaining witnesses
let solved_witness = solve_witness(compiled_program, inputs_map)?;
let solved_witness = execute_program(&compiled_program, &inputs_map)?;

let public_abi = compiled_program.abi.clone().public_abi();
let public_abi = compiled_program.abi.public_abi();
let public_inputs = public_abi.decode(&solved_witness)?;
let return_value = public_inputs.get(MAIN_RETURN_NAME).cloned();

Ok((return_value, solved_witness))
}

pub(crate) fn solve_witness(
pub(crate) fn execute_program(
compiled_program: &CompiledProgram,
input_map: &InputMap,
inputs_map: &InputMap,
) -> Result<WitnessMap, CliError> {
let mut solved_witness = compiled_program.abi.encode(input_map, true)?;
let mut solved_witness = compiled_program.abi.encode(inputs_map, true)?;

let backend = crate::backends::ConcreteBackend;
backend.solve(&mut solved_witness, compiled_program.circuit.opcodes.clone())?;
Expand Down
2 changes: 1 addition & 1 deletion crates/nargo/src/cli/prove_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ pub fn prove_with_path<P: AsRef<Path>>(
&compiled_program.abi,
)?;

let (_, solved_witness) = execute_program(&compiled_program, &inputs_map)?;
let solved_witness = execute_program(&compiled_program, &inputs_map)?;

// Write public inputs into Verifier.toml
let public_abi = compiled_program.abi.clone().public_abi();
Expand Down