Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Usability Issue] Cert list is not helpful and just lists the files #609

Closed
toddysm opened this issue Apr 1, 2023 · 0 comments · Fixed by #798
Closed

[Usability Issue] Cert list is not helpful and just lists the files #609

toddysm opened this issue Apr 1, 2023 · 0 comments · Fixed by #798
Assignees
@Two-Hearts
Labels
enhancement New feature or request UX User experience changes
Milestone
1.1.0

Comments

@toddysm
Copy link
Contributor

toddysm commented Apr 1, 2023

What is the areas you experience the issue in?

Notation CLI

What is not working as expected?

This is a usability/consistency issue. Compared to the notation key list command, the notation cert list is note very user-friendly because it lists only the file location. It would be helpful to have the command output additional details like type of cert etc. that will be needed for removal of the cert for example. At a min we should have what is described in #604 (comment)

What did you expect to happen?

At a minimum, use table output and provide details about the cert type and the cert store that is needed for removal of the cert.

How can we reproduce it?

notation cert list

Describe your environment

Notation: Notary v2, A tool to sign, store, and verify artifacts.

Version: 1.0.0-rc.3
Go version: go1.20.1
Git commit: 233c0ea

What is the version of your Notation CLI or Notation Library?

CLI
@toddysm toddysm added bug Something isn't working triage Need to triage labels Apr 1, 2023
@FeynmanZhou FeynmanZhou added the UX User experience changes label Apr 4, 2023
@yizha1 yizha1 added this to the 1.1.0 milestone Apr 26, 2023
@yizha1 yizha1 added enhancement New feature or request and removed bug Something isn't working triage Need to triage labels Apr 26, 2023
This was referenced Sep 5, 2023
Closed
Closed
Closed
@Two-Hearts Two-Hearts mentioned this issue Oct 10, 2023
Merged
@Two-Hearts Two-Hearts moved this from Todo to PR Review in Notary Project Planning Board Oct 10, 2023
priteshbandi pushed a commit that referenced this issue Oct 11, 2023
@Two-Hearts
feat: update notation cert list command output (#798)
f205e6b 
This PR updates the output format of `notation cert list` command. Resolves #609 and #772. Example output:
```
STORE TYPE         STORE NAME         CERTIFICATE   
ca                 myStore            myCert.pem    
```

Signed-off-by: Patrick Zheng <[email protected]>
@github-project-automation github-project-automation bot moved this from PR Review to Done in Notary Project Planning Board Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Two-Hearts Two-Hearts

Labels
enhancement New feature or request UX User experience changes
Projects
Notary Project Planning Board
Status: Done
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

feat: update notation cert list command output Two-Hearts/notation
4 participants
@toddysm @FeynmanZhou @yizha1 @Two-Hearts