Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use columns with labels for cert list output #772

Closed
sozercan opened this issue Sep 1, 2023 · 1 comment · Fixed by #798
Closed

Use columns with labels for cert list output #772

sozercan opened this issue Sep 1, 2023 · 1 comment · Fixed by #798
Assignees
@Two-Hearts
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Milestone
1.1.0

Comments

@sozercan
Copy link

sozercan commented Sep 1, 2023 •
edited
Loading

Is your feature request related to a problem?

If a user is not familiar with trust policy and cert list, they might be confused with the notation cert list output

$ notation cert list  
/home/sozercan/.config/notation/truststore/x509/ca/wabbit/wabbit-networks.io.crt
/home/sozercan/.config/notation/truststore/x509/ca/wabbit-networks.io/wabbit-networks.io.crt

It is not very clear that names of trust stores should be wabbit and wabbit-networks.io in this case

What solution do you propose?

It would be clearer to use columns that match the terms and expectations

Suggestion

$ notation cert list  
TRUST STORE              CERT PATH
wabbit                  /home/sozercan/.config/notation/truststore/x509/ca/wabbit/wabbit-networks.io.crt
wabbit-networks         /home/sozercan/.config/notation/truststore/x509/ca/wabbit-networks.io/wabbit-networks.io.crt

and anything else that might be helpful

What alternatives have you considered?

n/a

Any additional context?

No response
@sozercan sozercan added enhancement New feature or request triage Need to triage labels Sep 1, 2023
@yizha1 yizha1 added duplicate This issue or pull request already exists and removed triage Need to triage labels Sep 5, 2023
@yizha1
Copy link
Contributor

yizha1 commented Sep 5, 2023

duplicated with issue #609

@yizha1 yizha1 added this to the 1.1.0 milestone Sep 5, 2023
This was referenced Sep 5, 2023
Closed
Closed
@Two-Hearts Two-Hearts mentioned this issue Oct 10, 2023
Merged
@Two-Hearts Two-Hearts moved this from Todo to PR Review in Notary Project Planning Board Oct 10, 2023
priteshbandi pushed a commit that referenced this issue Oct 11, 2023
@Two-Hearts
feat: update notation cert list command output (#798)
f205e6b 
This PR updates the output format of `notation cert list` command. Resolves #609 and #772. Example output:
```
STORE TYPE         STORE NAME         CERTIFICATE   
ca                 myStore            myCert.pem    
```

Signed-off-by: Patrick Zheng <[email protected]>
@github-project-automation github-project-automation bot moved this from PR Review to Done in Notary Project Planning Board Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Two-Hearts Two-Hearts

Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
Notary Project Planning Board
Status: Done
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

feat: update notation cert list command output Two-Hearts/notation
3 participants
@sozercan @yizha1 @Two-Hearts