This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
🐛 Update IiifPrint and fix PDF splitting #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref notch8/iiif_print#256 - Updates IiifPrint to include fixes to Derivative Rodeo refactors. - Fixes incompatibilities in the custom Adventist PDF splitter.
laritakr
force-pushed
the
update-iiif-print-and-fix-pdf-splitting
branch
from
383fbf7 to
acd51f1
Compare
jeremyf
reviewed
Jul 6, 2023
added 2 commits
July 6, 2023 10:48
Also carry along args.
jeremyf
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Ref: notch8/adventist_knapsack#350
Updates IiifPrint to include fixes to Derivative Rodeo refactors and bug fixes
defaulttodefault_coordsiiif_print#257Fixes incompatibilities in the custom Adventist PDF splitter.
Expected Behavior Before Changes
IiifPrint job to split PDFs did not get called.
Expected Behavior After Changes
Gemfile includes DerivativeRodeo.
PDFs split correctly into child works.
Screenshots / Video
Notes
Move ticket to complete following SoftServe QA.