🐛 Restore PDF splitting functionality to main and bring in subsequent code changes #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this commit, we don't have insight into the resulting conditional submission of the file set.
Ref: https://github.com/scientist-softserv/adventist-dl/issues/469 Method `render_ocr_snippets` was causing AbstractController::DoubleRenderError () during random situations, due to including the IiifPrintHelper in ApplicationController. This pull request moves it into a helper module which is injected by the install generator, which matches how it was done in LV & NNP. See https://github.com/scientist-softserv/louisville-hyku/blob/b672d2a3213aaee84c082eb8083d8ad70733036b/app/helpers/newspaper_works_helper.rb#L3
Correct some refactoring of code for Derivative Rodeo. The exceptions from these errors should have been reported somewhere, but exceptions appear to be getting swallowed. Adding logging also did not capture the errors.
jeremyf
approved these changes
Jul 5, 2023
laritakr
pushed a commit
to notch8/adventist-dl
that referenced
this pull request
Jul 5, 2023
Ref notch8/iiif_print#256 - Updates IiifPrint to include fixes to Derivative Rodeo refactors. - Fixes incompatibilities in the custom Adventist PDF splitter.
laritakr
pushed a commit
to notch8/adventist-dl
that referenced
this pull request
Jul 5, 2023
Ref notch8/iiif_print#256 - Updates IiifPrint to include fixes to Derivative Rodeo refactors. - Fixes incompatibilities in the custom Adventist PDF splitter.
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Derivative Rodeo refactoring broke PDF splitting.
This pull request fixes PDF splitting, and brings in subsequent changes from the no-rodeo branch to bring main back up to date.
Refs
Expected Behavior Before Changes
PDF splitting was getting ignored.
Expected Behavior After Changes
PDFs split into viewable child works.
Screenshots / Video
Notes
Exceptions are being swallowed somewhere... the errors this bug caused should have been showing up in either worker logs or sentry, but they didn't.