Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery Theme Layout Bug #229

Closed
3 tasks
jillpe opened this issue Jun 10, 2024 · 1 comment
Closed
3 tasks

Gallery Theme Layout Bug #229

jillpe opened this issue Jun 10, 2024 · 1 comment
Assignees
@kirkkwang
Labels
Mobius Work related to mobius tenants

Comments

@jillpe
Copy link

jillpe commented Jun 10, 2024 •
edited by ShanaLMoore
Loading

Summary

related to:

Goal is to determine what needs to be fixed for the themes bug we are seeing on HykuUp/pals

From Mobius:
The sites are reporting some issues with the home page themes and the gallery and masonry
displays. They said all of the home page templates apart from the default appear to be
broken in their layout. I am attaching some screenshots.

Image

We can set the default here

Image

Acceptance Criteria
@ShanaLMoore ShanaLMoore added the spike needs investigation and planning label Jun 10, 2024
@ShanaLMoore ShanaLMoore changed the title Spike: Themes Layout Bug 🦄 Spike: Themes Layout Bug Jun 10, 2024
@ShanaLMoore ShanaLMoore added the Mobius Work related to mobius tenants label Jun 10, 2024
kirkkwang pushed a commit to samvera/hyku that referenced this issue Jun 11, 2024
🐛 Fix gallery and masonry catalog results styling
b39333f 
Previously, when the user looks at the catalog search results page and
sets the view to either gallery or masonry, the styling is really off.
Here this commit should fix that and also hide the bookmarks checkbox.
Hyrax dassie does not show it so we will mimic that until further notice
since the user can't even get to the /bookmarks route.

Ref:
  - notch8/hykuup_knapsack#229
@kirkkwang kirkkwang mentioned this issue Jun 11, 2024
Merged
@ShanaLMoore ShanaLMoore changed the title 🦄 Spike: Themes Layout Bug 🦄 Spike: Gallery Theme Layout Bug Jun 11, 2024
@ShanaLMoore ShanaLMoore changed the title 🦄 Spike: Gallery Theme Layout Bug Gallery Theme Layout Bug Jun 11, 2024
@ShanaLMoore ShanaLMoore removed the spike needs investigation and planning label Jun 11, 2024
ShanaLMoore pushed a commit that referenced this issue Jun 11, 2024
Update hyrax-webapp
8e1d8bc 
This pulls in bug fixes for the following
- #226
- #229
This was referenced Jun 11, 2024
Merged
Closed
@jillpe
Copy link
Author

jillpe commented Jun 13, 2024

SoftServ QA: ✅

Screen.Recording.2024-06-13.at.10.24.30.AM.mov

@jillpe jillpe closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
Mobius Work related to mobius tenants
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShanaLMoore @kirkkwang @jillpe