Refactoring specs to remove warning #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting method PluggableDerivativeService implementation
e7e0675
Prior to this commit, the
respond_to_missing?
method definition didnot have the correct method signature. Which could cause failures
elsewhere.
Also, as much as we don't want to repeat knowledge regarding
implementation details, most references to method_missing and the
sibling respond_to_missing duplicate logic; in part to minimize
unnecessary calls. (See Always Define respond_to_missing?)
I renamed
name
tomethod_name
to be consistent with theparameters of the sibling methods.
And last, I made a change in the logic test to short-circuit faster and
not reference the file_set if we don't have "agreeable" parameters.
References:
Removing RSpec matcher warning
ba0268f
Prior to this commit the specs included the following warning:
With this commit, we're removing that warning.
Less warnings, means less chatter.
Related to: