Refactoring specs to remove warning

app/services/iiif_print/pluggable_derivative_service.rb

@@ -41,7 +41,7 @@ def valid?
     true
   end
 
-  def respond_to_missing?(method_name)
+  def respond_to_missing?(method_name, include_private = false)
     allowed_methods.include?(method_name) || super
   end
 
@@ -56,14 +56,14 @@ def services(method_name)
     end
   end
 
-  def method_missing(name, *args, **opts, &block)
-    if respond_to_missing?(name)
+  def method_missing(method_name, *args, **opts, &block)
+    if allowed_methods.include?(method_name)
       # we have an allowed method, construct services and include all valid
       #   services for the file_set
       # services = plugins.map { |plugin| plugin.new(file_set) }.select(&:valid?)
       # run all valid services, in order:
-      services(name).each do |plugin|
-        plugin.send(name, *args)
+      services(method_name).each do |plugin|
+        plugin.send(method_name, *args)
       end
     else
       super
@@ -73,8 +73,11 @@ def method_missing(name, *args, **opts, &block)
   private
 
   def skip_destination?(method_name, destination_name)
-    return false if file_set.id.nil? || destination_name.nil?
     return false unless method_name == :create_derivatives
+    return false unless destination_name
+    # NOTE: What are we after with this nil test?  Are we looking for persisted objects?
+    return false if file_set.id.nil?
+
     # skip :create_derivatives if existing --> do not re-create
     existing_derivative?(destination_name) ||
       impending_derivative?(destination_name)

spec/models/iiif_print/derivative_attachment_spec.rb

@@ -15,23 +15,23 @@ module IiifPrint
         destination_name: 'txt'
       )
       # attempt save without required data; expect failure
-      expect { model.save! }.not_to raise_exception(ActiveRecord::RecordInvalid)
+      expect { model.save! }.not_to raise_exception
     end
 
     it "saves when all fields completely set" do
       model = described_class.create
       model.fileset_id = 'someid123'
       model.path = '/path/to/somefile'
       model.destination_name = 'txt'
-      expect { model.save! }.not_to raise_exception(ActiveRecord::RecordInvalid)
+      expect { model.save! }.not_to raise_exception
     end
 
     it "saves when only path, destination_name set" do
       model = described_class.create
       model.fileset_id = nil
       model.path = '/path/to/somefile'
       model.destination_name = 'txt'
-      expect { model.save! }.not_to raise_exception(ActiveRecord::RecordInvalid)
+      expect { model.save! }.not_to raise_exception
     end
   end
 end

spec/models/iiif_print/ingest_file_relation_spec.rb

@@ -36,14 +36,14 @@ def make_test_records
         file_path: '/path/to/this',
         derivative_path: '/path/to/that'
       )
-      expect { model.save! }.not_to raise_exception(ActiveRecord::RecordInvalid)
+      expect { model.save! }.not_to raise_exception
     end
 
     it "will save when all fields completely set" do
       model = described_class.create
       model.file_path = '/path/to/sourcefile.tiff'
       model.derivative_path = '/path/to/derived.jp2'
-      expect { model.save! }.not_to raise_exception(ActiveRecord::RecordInvalid)
+      expect { model.save! }.not_to raise_exception
     end
 
     it "can query derivative paths for primary file" do