Omit syntax warnings from command #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDF splitting was locking up during splitting command.
2 tasks
jeremyf
approved these changes
Apr 19, 2023
jeremyf
added a commit
to notch8/derivative-rodeo
that referenced
this pull request
Apr 21, 2023
This was ported over from the IIIF Print gem. Related to: - notch8/iiif_print#223 - notch8/britishlibrary#385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
PDF splitting was locking up during splitting command.
Refs notch8/britishlibrary#385
Expected Behavior Before Changes
IiifPrint::Jobs::ChildWorksFromPdfJob hung in sidekiq and had to be cancelled. The file did not get split.
Expected Behavior After Changes
File now splits correctly but universal viewer breaks due to solr query too large. This is a new bug ticket.
Screenshots / Video
Notes