Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic file import fails pdf splitting #385

Closed
1 task
laritakr opened this issue Apr 17, 2023 · 6 comments
Closed
1 task

Arabic file import fails pdf splitting #385

laritakr opened this issue Apr 17, 2023 · 6 comments
Assignees
Labels
bug Something isn't working SL-CSI Service Label: Current service incident

Comments

@laritakr
Copy link
Contributor

laritakr commented Apr 17, 2023

Story

Work: https://bl.bl-staging.notch8.cloud/concern/books/8beed1ee-e4ef-412e-92b3-8718ca8e3e10

The arabic file on this work is just sitting in sidekiq during the pdf split process and not doing anything. It appears to be locking up on Open3.popen3(cmd) do |_stdin, stdout, _stderr, _wait_thr| line. Is there a better way to open the pdf file and run the ghostscript command on it?

See also:

Acceptance Criteria

  • Identify reason arabic PDF is unable to split and resolve if possible.

Screenshots

Screenshot 2023-04-17 at 3 58 51 PM

Screenshot 2023-04-17 at 3 55 35 PM

Testing Instructions and Sample Files

Notes

@laritakr laritakr added the bug Something isn't working label Apr 17, 2023
@jillpe jillpe moved this to Ready for Development in britishlibrary Apr 19, 2023
@laritakr
Copy link
Contributor Author

laritakr commented Apr 19, 2023

Requires IiifPrint gem update.

UV issue requires notch8/iiif_print#224 fix. Will come at a later point.

@jillpe
Copy link

jillpe commented Apr 21, 2023

IiifPrint update handled in #313

@jillpe jillpe moved this from Ready for Development to Deploy to Staging in britishlibrary Apr 21, 2023
@laritakr laritakr removed the Blocked label Apr 21, 2023
jeremyf added a commit to notch8/derivative-rodeo that referenced this issue Apr 21, 2023
This was ported over from the IIIF Print gem.

Related to:

- notch8/iiif_print#223
- notch8/britishlibrary#385
@kirkkwang kirkkwang moved this from Deploy to Staging to SoftServ QA in britishlibrary Apr 21, 2023
@DiemBTran
Copy link
Contributor

This passes SoftServ QA: See attached screenshot.

tested on:

testing instructions

arabic PDFs are split into child pages

Book Arabic file import fails pdf splitting #385 ID 823e2226-e64c-4a62-82de-026bcb4997c9 Hyku 2023-04-24 at 6 40 01 PM

@DiemBTran DiemBTran moved this from SoftServ QA to Client QA in britishlibrary Apr 25, 2023
@grahamjevon
Copy link
Collaborator

Hi @laritakr - the specific test instructions are successful. However, when I replicated the real life scenario of uploading two pdf files (the English book and the Arabic translation) at the point of adding a new work, there was some unexpected behaviour. The most obvious sign of this is that the first split page displayed is page 039 (see screenshot below). This suggests that either some pages have not been split (yet?) or that something unexpected has happened to the ordering of the split pages.

Image

I notice there are split pages still appearing on the recent works feed despite the fact that I added this work about 24 hours ago (I'm assuming these are from my upload and not a subsequent SoftServ test). Is there another backlog?

Image

I wasn't sure whether to pass this ticket through QA and flag this unexpected behaviour as a different issue. I suspect you will know better whether this is related or distinct.

@laritakr
Copy link
Contributor Author

laritakr commented May 3, 2023

Hi @grahamjevon This seems to be a completely separate issue, and also recently happened with another client as well. I'm really stumped on it but haven't had time yet to track down a cause - these randomly occurring issues are tough to duplicate and trace! (I checked and did not see anything remaining in sidekiq)

We definitely need a new ticket for this behavior.

@grahamjevon
Copy link
Collaborator

Thanks @laritakr - In that case I will pass this ticket through QA and I have created another ticket for this new issue #401.

@grahamjevon grahamjevon moved this from Client QA to Deploy to Production in britishlibrary May 3, 2023
@cziaarm cziaarm added the SL-CSI Service Label: Current service incident label May 24, 2023
@ShanaLMoore ShanaLMoore moved this from Deploy to Production to Client Verification in britishlibrary May 24, 2023
@grahamjevon grahamjevon moved this from Client Verification to Done in britishlibrary Jun 1, 2023
@jillpe jillpe closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SL-CSI Service Label: Current service incident
Projects
Status: Done
Development

No branches or pull requests

6 participants