Fix pdf resplitting #380
Merged
Fix pdf resplitting #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few pieces of the pdf resplitting process that were not fully valkyrized. This commit valkyrizes the resplitting, and fixes a bug with removing the child works from the initial split. Ref notch8/palni_palci_knapsack#80
ShanaLMoore
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
There were a few pieces of the pdf resplitting process that were not fully valkyrized.
Ref notch8/palni_palci_knapsack#80
Expected Behavior Before Changes
PDF resplitting had numerous errors
Expected Behavior After Changes
Using the PDF resplit button successfully removes prior child works and creates new ones
Deleting a work which has child works split from a PDF will also delete the child works.
Screenshots / Video
Original work with "highlighted" child works:
After resplit (highlighted works were deleted & replaced with new child work)
Original child work no longer found
Notes