"Resplit PDF" button produces error

[ndroark]

The "Resplit this pdf" button on the Fileset page produces a "You are not authorized to access this page" for a superadmin user, example: https://nicdon.palni-palci-staging.notch8.cloud/concern/parent/f7a1fe4c-c553-420d-9205-0402d577df4a/file_sets/3e3e018f-096c-486d-8dc2-22b3cd665d7a

Acceptance Criteria

• Fix PDF resplitting option

Screenshots or Video

Hyku Main:

Testing Instructions

Create a work with a PDF (be sure feature flipper is set so the PDF splits into child works).
Go to the PDF file set page and click the option to re-split the pdf.

• New child works are created from the PDF and attached to the parent work
• All prior child works are deleted

Notes

v3 no longer supports active fedora

[jillpe]

IIIF print issue. Related to notch8/iiif_print#294

[ShanaLMoore]

I've only done some sleuthing so far; I don't have a branch with code changes.

I was able to reproduce this in local Hyku.

I noticed the where clauses need to be updated to valkyrie queries.

Then the #pdf? is not a method error is because file_set.pdf? needs to be updated to file_set.original_file.pdf?. Same goes for #mime_type => file_set.original_file.mime_type. Or I suppose we could introduce a helper method.

cc @laritakr handing it back over to you since you may already have had WIP.

[ShanaLMoore]

QA RESULTS: ❌ NEEDS REWORK

tested on STAGING

Before clicking re split led to a 500 error page.

Now the user will get a success message that the job is enqueued:

However, after the jobs completed I am not able to view the pages in the UV and the pages have lost their thumbnails.

Additionally, if I try to download one of the pages it says it cant be found:

cc @laritakr could you have a look and pull this back for rework if more needs to be done here?

[laritakr]

The remaining problem is that Hyrax's BatchCreateJob is not consistently enqueuing the CreateWorkJob with the uploaded_files attribute.

In BatchCreateJob below, the array of upload_ids ["1639", "1640"] should iterate and create two CreateWorkJobs, with attributes uploaded_files: [upload_id]. However, in almost every situation in staging, the uploaded_files attribute is missing so the job can't find the file to attach.

I, [2025-02-03T21:20:09.511182 #1]  INFO -- : [ActiveJob] [IiifPrint::Jobs::ChildWorksFromPdfJob] [bc288646-6e67-4b16-bc17-61d3d7fab203] Enqueued BatchCreateJob (Job ID: b6626a13-0372-4847-ae5e-c165792123ab) to Sidekiq(default) with arguments: #<GlobalID:0x00007f8e25af48e8 @uri=#<URI::GID gid://hyku/User/1>>, {"1639"=>"7c23603a-346e-4ec6-bcde-aac7c3d86e47 - iiif-print-test.pdf Page 1", "1640"=>"7c23603a-346e-4ec6-bcde-aac7c3d86e47 - iiif-print-test.pdf Page 2"}, {"1639"=>["Image"], "1640"=>["Image"]}, ["1639", "1640"], {"admin_set_id"=>"admin_set/default", "creator"=>["snoopy"], "keyword"=>["snoopy"], "rights_statement"=>["http://rightsstatements.org/vocab/NKC/1.0/"], "is_child"=>true, "visibility"=>"open", "model"=>"GenericWorkResource", "split_from_pdf_id"=>"41c75dc9-ffa5-4b46-aaf7-f8975b0cc4ee"}, #<GlobalID:0x00007f8e25af3330 @uri=#<URI::GID gid://hyku/Hyrax::BatchCreateOperation/1151>>

I, [2025-02-03T21:22:05.985647 #1]  INFO -- : [ActiveJob] Enqueued CreateWorkJob (Job ID: b7a01964-7c08-40fd-b9e3-66ecdb66b153) to Sidekiq(default) at 2025-02-03 21:26:23 UTC with arguments: #<GlobalID:0x00007f8e327c7528 @uri=#<URI::GID gid://hyku/User/1>>, "GenericWorkResource", {"admin_set_id"=>"admin_set/default", "creator"=>["snoopy"], "keyword"=>["snoopy"], "rights_statement"=>["http://rightsstatements.org/vocab/NKC/1.0/"], "is_child"=>true, "visibility"=>"open", "split_from_pdf_id"=>"41c75dc9-ffa5-4b46-aaf7-f8975b0cc4ee", "title"=>["7c23603a-346e-4ec6-bcde-aac7c3d86e47 - iiif-print-test.pdf Page 1"], "resource_type"=>["Image"]}, #<GlobalID:0x00007f8e327c2bb8 @uri=#<URI::GID gid://hyku/Hyrax::Operation/1152>>

The logic in Hyrax has not changed anytime recently, and it doesn't make sense why this would be happening:

  def create(user, titles, resource_types, uploaded_files, attributes, operation)
    model = attributes.delete(:model) || attributes.delete('model')
    raise ArgumentError, 'attributes must include "model" => ClassName.to_s' unless model

    uploaded_files.each do |upload_id|
      title = [titles[upload_id]] if titles[upload_id]
      resource_type = Array.wrap(resource_types[upload_id]) if resource_types[upload_id]
      attributes = attributes.merge(uploaded_files: [upload_id],
                                    title: title,
                                    resource_type: resource_type)
      child_operation = Hyrax::Operation.create!(user: user,
                                                 operation_type: "Create Work",
                                                 parent: operation)
      CreateWorkJob.perform_later(user, model, attributes, child_operation)
    end

[laritakr]

Additional notes to above:

CreateWorkJob is submitted correctly with parameters. As it runs it receives an error RuntimeError (The value for :adapter was not found in the blacklight.yml config). When it gets resubmitted, it no longer has the uploaded_files: [upload_id] attribute, causing it to fail with a different error.

[laritakr]

Fixed by samvera/hyku#2445 and #231