Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel isn't fixed size like it used to be #249

Open
ShanaLMoore opened this issue Feb 15, 2025 · 2 comments
Open

Carousel isn't fixed size like it used to be #249

ShanaLMoore opened this issue Feb 15, 2025 · 2 comments
Assignees
@sjproctor
Labels
cutover bug

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Feb 15, 2025 •
edited
Loading

Summary

Carousel in featured works should be fixed: https://mushare.marian.edu/

Image

Acceptance Criteria

  • [ ]

Screenshots or Video

Testing Instructions

To be filled out by dev

Notes
@ShanaLMoore ShanaLMoore added bug something isn't working cutover bug and removed bug something isn't working labels Feb 15, 2025
@jillpe
Copy link

jillpe commented Feb 17, 2025

Is this an assetsCompile issue?

@sjproctor
Copy link
Contributor

Replicating the Problem

  • On production
  • Must be on the Neutral Theme
  • User must be logged out
  • Must be two or more featured works

❌ Blocked by not being able to add images

@sjproctor sjproctor self-assigned this Feb 18, 2025
@jillpe jillpe moved this to In Development in PalsKnapsack Feb 19, 2025
sjproctor added a commit to samvera/hyku that referenced this issue Feb 19, 2025
@sjproctor
🐛 Standardize carousel container dimensions
c40a875 
This commit:
- adds a fixed height container (400px) to maintain consistent carousel
size even when images have different dimensions
- adds object-fit and transition properties to prevent image stretching
during slide transitions
- favors Bootstrap classes where possible
- improves image positioning and aspect ratio handling in carousel items

Ref:
- notch8/palni_palci_knapsack#249
@sjproctor sjproctor mentioned this issue Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjproctor sjproctor

Labels
cutover bug
Projects
PalsKnapsack
Status: In Development
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShanaLMoore @sjproctor @jillpe