Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Standardize carousel container dimensions #2465

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

sjproctor
Copy link
Collaborator

Story: [i249] Standardize featured works carousel container dimensions in logged-out view of Neutral Theme

Ref:

Expected Behavior Before Changes

  • Carousel container resized based on image dimensions causing page layout shifts
  • Image transitions were jumpy
Video: Before changes
Screen.Recording.2025-02-19.at.12.08.31.PM.mov

Expected Behavior After Changes

  • Set container height and standard image size
  • Smooth transition during carousel changes
Video: After changes
Screen.Recording.2025-02-19.at.12.10.20.PM.mov

Notes

  • adds a fixed height container (400px) to maintain consistent carousel size even when images have different dimensions
  • adds object-fit and transition properties to prevent image stretching during slide transitions
  • favors Bootstrap classes where possible
  • improves image positioning and aspect ratio handling in carousel items

@samvera/hyku-code-reviewers

This commit:
- adds a fixed height container (400px) to maintain consistent carousel
size even when images have different dimensions
- adds object-fit and transition properties to prevent image stretching
during slide transitions
- favors Bootstrap classes where possible
- improves image positioning and aspect ratio handling in carousel items

Ref:
- notch8/palni_palci_knapsack#249
@sjproctor sjproctor added the ignore-for-release ignore this for release notes label Feb 19, 2025
Copy link
Collaborator

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better!

Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 36s ⏱️ +28s
2 064 tests ±0  2 008 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 091 runs  ±0  2 033 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit c40a875. ± Comparison against base commit 97e32b5.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy c9754ed3-764f-4f07-ab0a-f685e1f3f300
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 27eb3418-7d45-40b3-a771-7e4b2ebda2f3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 89ed105b-578e-4b87-9c7a-e3c43929779b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 08d8aabd-cd06-4cb8-84ef-c03c5f403659
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 51ebb810-a570-4263-980e-3e7f2fc7e7cd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit eebb5765-3c88-4dfb-a582-05d3c645b220
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 259058d2-a541-4150-8765-96ab3a4c9da0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 55dd582a-4c41-45bb-bb5e-cff01a1449e2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 1f1ac4f5-ef9d-44cf-b8fd-4bcd4ec478e7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5d05bb16-a663-4ef7-b93d-fa612f4145fb
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a2abf609-5c2d-4ef1-a206-f108de0f243b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 3b71170f-3d24-40ae-823a-6f4d473f52e7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f1ef7268-54ea-450a-8b93-b942610f8d20
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update f4c7bbbf-aa37-4f79-bb7d-da1f5bcd6377
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 8c41faa6-9268-43cb-8fe0-d92f30e31ea4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a027ee81-a265-4dc1-965f-f31dde860656
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read baf56403-366c-4072-b4bc-a8ba482eac73
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 9fe617d5-e717-4202-b5b8-ee9e65964849
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 23a71de7-0ab7-4513-bad9-57be4876d8da
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit cd01d766-54f7-4a47-af9e-4a883b518121
…

@sjproctor sjproctor merged commit d3a0541 into main Feb 19, 2025
9 checks passed
@sjproctor sjproctor deleted the i249-neutral-theme-carousel-resizing branch February 19, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants