-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Standardize carousel container dimensions #2465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - adds a fixed height container (400px) to maintain consistent carousel size even when images have different dimensions - adds object-fit and transition properties to prevent image stretching during slide transitions - favors Bootstrap classes where possible - improves image positioning and aspect ratio handling in carousel items Ref: - notch8/palni_palci_knapsack#249
laritakr
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so much better!
Test Results 3 files ±0 3 suites ±0 17m 36s ⏱️ +28s Results for commit c40a875. ± Comparison against base commit 97e32b5. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: [i249] Standardize featured works carousel container dimensions in logged-out view of Neutral Theme
Ref:
Expected Behavior Before Changes
Video: Before changes
Screen.Recording.2025-02-19.at.12.08.31.PM.mov
Expected Behavior After Changes
Video: After changes
Screen.Recording.2025-02-19.at.12.10.20.PM.mov
Notes
@samvera/hyku-code-reviewers