-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🦄 Spike: Use Alternative Text as entered in appearance tabs #43
Comments
Linked items:
|
Related MRs: |
related to #387 |
I think this work may already done/contributed back? cc @jillpe Per this PR and this comment which states that the work was done in hyku. UTK received it by pulling in hyku's latest. STAGING: Appearance tab the user is able to enter an alt text where it's applicable: |
Reopen to confirm that the alt text is being used when a user sets them |
QA Results: Fail. When using an alt text extension it appears that many of these instances are failing. Logo: I am not seeing it appear on hover however I can see that the alt tag is present upon inspection ⚠ Banner Image: The alt text appears on hover however the alt tag is not set upon inspection ⚠ |
I am closing this ticket to create an implementation ticket. Work needs to be done. |
This ticket was to confirm that the user can set the alt text and that it is used in the html. We discoverd that some of the settable alt text options are not being used in the html and updated the ones that were. - Issue #43
This ticket was to confirm that the user can set the alt text and that it is used in the html. We discoverd that some of the settable alt text options are not being used in the html and updated the ones that were. - Issue #43
Update: The work for this seems to be done. This ticket has been changed into a spike for a dev to confirm that the alt text is getting used when a user sets them. If not, a ticket should be created to implement such.
ref:
Related to ticket #54
Summary
Some images and alt text entered in appearance menu tabs are not currently used. It is most important for the public pages to include the alt text.
Where are these images used?
Default collection thumbnail is used inside the dashboard on the collection view, as well as on thumbnails for catalog search results and on featured collections.
A default work thumbnail is only used if characterization fails to create a custom thumbnail, or if characterization has not yet run. However, the partials come from hyrax, so the hyku default work thumbnail is not being used.
Note that custom thumbnails also do not currently have the ability to use alt text
Directory images are used only on customized homepages. If a customized homepage is developed, the images need to use the corresponding alt text as well.
Acceptance Criteria
Use alt text as entered in Appearance Menu
Screenshots or Video
Testing Instructions
Notes
Confused how to fill this out? Check out the playbook
The text was updated successfully, but these errors were encountered: