Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦄 Spike: Use Alternative Text as entered in appearance tabs #43

Closed
Tracked by #407 ...
orangewolf opened this issue Oct 18, 2022 · 7 comments
Closed
Tracked by #407 ...

🦄 Spike: Use Alternative Text as entered in appearance tabs #43

orangewolf opened this issue Oct 18, 2022 · 7 comments

Comments

@orangewolf
Copy link
Contributor

orangewolf commented Oct 18, 2022

Update: The work for this seems to be done. This ticket has been changed into a spike for a dev to confirm that the alt text is getting used when a user sets them. If not, a ticket should be created to implement such.

ref:

Related to ticket #54

Summary

Some images and alt text entered in appearance menu tabs are not currently used. It is most important for the public pages to include the alt text.

Where are these images used?

  • Default collection thumbnail is used inside the dashboard on the collection view, as well as on thumbnails for catalog search results and on featured collections.

  • A default work thumbnail is only used if characterization fails to create a custom thumbnail, or if characterization has not yet run. However, the partials come from hyrax, so the hyku default work thumbnail is not being used.
    Note that custom thumbnails also do not currently have the ability to use alt text

  • Directory images are used only on customized homepages. If a customized homepage is developed, the images need to use the corresponding alt text as well.

Acceptance Criteria

Use alt text as entered in Appearance Menu

Screenshots or Video

Testing Instructions

Notes

Confused how to fill this out? Check out the playbook

@crisr15 crisr15 added this to utk-hyku Oct 26, 2022
@DiemBTran
Copy link
Contributor

Linked items:

  • [5] 1.1 Text Alternatives
  • EPIC: Accessibility Improvements

@DiemBTran
Copy link
Contributor

Related MRs:

@jillpe
Copy link

jillpe commented Apr 19, 2023

related to #387

@jillpe jillpe removed the DC label Apr 20, 2023
@jillpe jillpe added this to the Digital Collections milestone Apr 20, 2023
@jillpe jillpe modified the milestones: Milestone 1, Milestone 2 May 11, 2023
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jul 13, 2023

I think this work may already done/contributed back? cc @jillpe Per this PR and this comment which states that the work was done in hyku. UTK received it by pulling in hyku's latest.

STAGING: Appearance tab the user is able to enter an alt text where it's applicable:

Image

Image

Image

Image

@jillpe jillpe closed this as completed Jul 14, 2023
@github-project-automation github-project-automation bot moved this to Done in utk-hyku Jul 14, 2023
@ShanaLMoore ShanaLMoore reopened this Jul 14, 2023
@github-project-automation github-project-automation bot moved this from Done to Ready for Development in utk-hyku Jul 14, 2023
@ShanaLMoore
Copy link
Contributor

Reopen to confirm that the alt text is being used when a user sets them

@ShanaLMoore ShanaLMoore changed the title Use Alternative Text as entered in appearance tabs 🦄 Spike: Use Alternative Text as entered in appearance tabs Jul 14, 2023
@ShanaLMoore ShanaLMoore moved this from Ready for Development to SoftServ QA in utk-hyku Jul 14, 2023
@ShanaLMoore ShanaLMoore moved this from SoftServ QA to Ready for Development in utk-hyku Jul 14, 2023
@ShanaLMoore ShanaLMoore self-assigned this Jul 18, 2023
@ShanaLMoore ShanaLMoore moved this from Ready for Development to In Development in utk-hyku Jul 18, 2023
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jul 18, 2023

QA Results: Fail. When using an alt text extension it appears that many of these instances are failing.

Logo: I am not seeing it appear on hover however I can see that the alt tag is present upon inspection ⚠

Image

Banner Image: The alt text appears on hover however the alt tag is not set upon inspection ⚠

Image

Image

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Jul 18, 2023

I am closing this ticket to create an implementation ticket. Work needs to be done.

ShanaLMoore pushed a commit that referenced this issue Jul 18, 2023
This ticket was to confirm that the user can set
the alt text and that it is used in the html. We
discoverd that some of the settable alt text
options are not being used in the html and updated
the ones that were.

- Issue #43
ShanaLMoore pushed a commit that referenced this issue Jul 18, 2023
This ticket was to confirm that the user can set
the alt text and that it is used in the html. We
discoverd that some of the settable alt text
options are not being used in the html and updated
the ones that were.

- Issue #43
@github-project-automation github-project-automation bot moved this from In Development to Done in utk-hyku Jul 18, 2023
@ShanaLMoore ShanaLMoore mentioned this issue Jul 18, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants