Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 update partials to use alt tags per accessibility audit #1966

Closed
wants to merge 2 commits into from

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Jul 18, 2023

Story

This ticket was to confirm that the user can set the alt text and that it is used in the html. We discovered that some of the settable alt text options are not being used in the html and updated the ones that were. Alt Text Tool: https://chrome.google.com/webstore/detail/alt-text-tester/koldhcllpbdfcdpfpbldbicbgddglodk

directory_image_text is not being used in a view: https://github.com/search?q=repo%3Asamvera%2Fhyku+directory_image_text&type=code

default_collection_image_text is not being used in a view: https://github.com/search?q=repo%3Asamvera%2Fhyku%20default_collection_image_text&type=code

default_work_image_text is not being used in a view: https://github.com/search?q=repo%3Asamvera%2Fhyku+default_work_image_text&type=code

Expected Behavior Before Changes

Alt text was not present in the inspect element. Using an alt text extension tool also confirmed this.

Expected Behavior After Changes

Screenshot 2023-07-18 at 9 20 06 AM

This ticket was to confirm that the user can set
the alt text and that it is used in the html. We
discoverd that some of the settable alt text
options are not being used in the html and updated the ones that were.

    Issue
🦄 Spike: Use Alternative Text as entered in appearance tabs #43

ref: notch8/utk-hyku#469
alt attribute can't be used with div tags but screen readers typically do not read the alt text of background images because they are considered decorative and not essential for conveying information. The alt attribute is specifically intended for images inserted within the HTML content.
@ShanaLMoore ShanaLMoore marked this pull request as draft July 18, 2023 18:48
@ShanaLMoore
Copy link
Collaborator Author

Closing as this requires an upgrade to iiif_print and its current state is not ready to be contributed back. We will do so once the derivative rodeo work is complete. ref: notch8/utk-hyku#474

@ShanaLMoore ShanaLMoore deleted the 43-use-alt-text-tags branch September 1, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant