Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: equation #25

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: equation #25

merged 1 commit into from
Sep 23, 2024

Conversation

p-iknow
Copy link
Member

@p-iknow p-iknow commented Sep 22, 2024 •
edited
Loading

Description of Changes

support equation block

Review point

  • Instead of adding the react-katex dependency, should I create a custom solution specifically for this project?
  • CSS imports are side effects, so how should sideEffects be specified in this module's npm configuration?

To reproduce

  • npm run story:start
  • click equation on the storybook left side panel

Screenshot

image

@myjeong19 myjeong19 mentioned this pull request Sep 23, 2024
Merged
Moon-DaeSeung
Moon-DaeSeung approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Moon-DaeSeung Moon-DaeSeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Moon-DaeSeung Moon-DaeSeung merged commit bcd56f8 into main Sep 23, 2024
@Moon-DaeSeung Moon-DaeSeung deleted the feat-equation branch September 23, 2024 14:05
@Moon-DaeSeung Moon-DaeSeung mentioned this pull request Sep 23, 2024
Closed
@myjeong19 myjeong19 mentioned this pull request Sep 24, 2024
Merged
@kimfield98 kimfield98 mentioned this pull request Sep 25, 2024
Merged
@myjeong19 myjeong19 mentioned this pull request Sep 25, 2024
Merged
This was referenced Sep 26, 2024
Merged
Merged
Merged
Merged
This was referenced Sep 27, 2024
Merged
Merged
Merged
@myjeong19 myjeong19 mentioned this pull request Oct 1, 2024
Merged
@Moon-DaeSeung Moon-DaeSeung mentioned this pull request Oct 3, 2024
Merged
@anonymousRecords anonymousRecords mentioned this pull request Oct 5, 2024
Merged
@Moon-DaeSeung Moon-DaeSeung mentioned this pull request Oct 6, 2024
Merged
@anonymousRecords anonymousRecords mentioned this pull request Oct 7, 2024
Open
33 tasks
@anonymousRecords anonymousRecords added the enhancement New feature or request label Oct 7, 2024
@myjeong19 myjeong19 mentioned this pull request Oct 12, 2024
Merged
@anonymousRecords anonymousRecords mentioned this pull request Oct 13, 2024
Merged
@Moon-DaeSeung Moon-DaeSeung mentioned this pull request Oct 22, 2024
Merged
This was referenced Oct 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moon-DaeSeung Moon-DaeSeung Moon-DaeSeung approved these changes

@myjeong19 myjeong19 Awaiting requested review from myjeong19

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-iknow @Moon-DaeSeung @anonymousRecords