Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Divider component #32

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

anonymousRecords
Copy link
Member

Description of Changes

Here is reference: #25


support 'Divider' block

  • add custom solution for rendering 'Divider' block.

Review point

  • I used the color rgba(223, 223, 222, 1) for the divider, which I confirmed by capturing it from Notion. Is this approach acceptable?
  • In the DividerArgs type definition, I simplified it to only include the type property:
export type DividerArgs = {
  type: "divider";
} & ContextedBlock;

Is this simplification appropriate, or should we maintain the empty divider object for consistency with other block types?

To reproduce

  • npm run story:start
  • click 'your created block' on the Storybook left side panel

Screenshot

image

Review Guide

Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

@Moon-DaeSeung Moon-DaeSeung added the enhancement New feature or request label Sep 26, 2024
Copy link
Contributor

@Moon-DaeSeung Moon-DaeSeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Moon-DaeSeung Moon-DaeSeung merged commit 7650d09 into notionpresso:main Sep 26, 2024
@anonymousRecords anonymousRecords linked an issue Sep 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Divider notion block
2 participants