Put default timeout back to zero #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re: #26 Re: npm/cli#1151 The documented default timeout of 30s was not being set in v4, so we "fixed the glitch" in v4.0.3, causing problems for people trying to download large packages. There's no npm v6 way to specify what timeout to use, so not having a timeout at all seems like a reasonable default for the v4 line, at least. Let's roll back that change, and document it. (Arguably, fixing this bug was a breaking change, and we ought to roll it back.) This effectively reverts 69c2977, with documentation of the effective behavior before the change.
|
Hi @isaacs and @darcyclarke, sorry for forcing, but original bug npm/cli#1151 is a bit annoying |
|
@sidoruk-sv no worries about the ping, and apologies for the delay here, we're going to cut a release today and get this fix out in |
isaacs
added a commit
that referenced
this pull request
Apr 28, 2020
Re: #26 Re: npm/cli#1151 The documented default timeout of 30s was not being set in v4, so we "fixed the glitch" in v4.0.3, causing problems for people trying to download large packages. There's no npm v6 way to specify what timeout to use, so not having a timeout at all seems like a reasonable default for the v4 line, at least. Let's roll back that change, and document it. (Arguably, fixing this bug was a breaking change, and we ought to roll it back.) This effectively reverts 69c2977, with documentation of the effective behavior before the change. PR-URL: #27 Credit: @isaacs Close: #27 Reviewed-by: @isaacs
|
Landed on fc5d94c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #26
Re: npm/cli#1151
The documented default timeout of 30s was not being set in v4, so we
"fixed the glitch" in v4.0.3, causing problems for people trying to
download large packages.
There's no npm v6 way to specify what timeout to use, so not having a
timeout at all seems like a reasonable default for the v4 line, at
least. Let's roll back that change, and document it. (Arguably, fixing
this bug was a breaking change, and we ought to roll it back.)
This effectively reverts 69c2977, with
documentation of the effective behavior before the change.