Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put default timeout back to zero #27

Closed
wants to merge 1 commit into from
Closed

Put default timeout back to zero #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ See also [`opts.ca`](#opts-ca).
##### <a name="opts-timeout"></a> `opts.timeout`

* Type: Milliseconds
* Default: 30000 (30 seconds)
* Default: 0 (no timeout)

Time before a hanging request times out.

Expand Down
2 changes: 1 addition & 1 deletion config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ module.exports = figgyPudding({
'spec': {},
'strict-ssl': {},
'timeout': {
default: 30 * 1000
default: 0
},
'user-agent': {
default: `${
Expand Down
2 changes: 1 addition & 1 deletion test/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test('isFromCI config option', t => {

test('default timeout', t => {
const DEFAULT_OPTS = config({})
t.equal(DEFAULT_OPTS.timeout, 30 * 1000, 'default timeout is 30s')
t.equal(DEFAULT_OPTS.timeout, 0, 'default timeout is 0 (no timeout)')
const SPECIFIED_OPTS = config({
timeout: 15 * 1000
})
Expand Down